Skip to content

[pigeon] made it so async java handlers can report errors - #460

Merged
gaaclarke merged 1 commit into
flutter:masterfrom
gaaclarke:pigeon-java-async-error
Sep 8, 2021
Merged

[pigeon] made it so async java handlers can report errors#460
gaaclarke merged 1 commit into
flutter:masterfrom
gaaclarke:pigeon-java-async-error

Conversation

@gaaclarke

@gaaclarke gaaclarke commented Sep 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

fixes flutter/flutter#83244

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla Bot added the cla: yes label Sep 7, 2021
@gaaclarke
gaaclarke force-pushed the pigeon-java-async-error branch 5 times, most recently from 7470f54 to 96f75ad Compare September 7, 2021 21:19
@gaaclarke
gaaclarke force-pushed the pigeon-java-async-error branch from 96f75ad to bb897cc Compare September 7, 2021 21:23
@gaaclarke
gaaclarke marked this pull request as ready for review September 7, 2021 21:27
@gaaclarke gaaclarke mentioned this pull request Sep 7, 2021
Closed
stuartmorgan-g
stuartmorgan-g reviewed Sep 8, 2021
View reviewed changes
Comment thread packages/pigeon/lib/java_generator.dart
stuartmorgan-g
stuartmorgan-g approved these changes Sep 8, 2021
View reviewed changes

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke
gaaclarke merged commit d8c10c7 into flutter:master Sep 8, 2021
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@gaaclarke
[pigeon] made it so async java handlers can report errors (flutter#460)
b9f16e0
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@gaaclarke
[pigeon] made it so async java handlers can report errors (flutter#460)
8dd25e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

cla: yes p: pigeon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add "error" method to the Result interface in Pigeon

2 participants

@gaaclarke @stuartmorgan-g