Skip to content

Update README of package:process - #5475

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
bartekpacia:chore/remove_record_replay_reference
Jan 25, 2024
Merged

auto-submit[bot] merged 1 commit into
flutter:mainfrom
bartekpacia:chore/remove_record_replay_reference

Conversation

@bartekpacia

Copy link
Copy Markdown
Member

This PR fixes flutter/flutter#136221.

BTW it's a great package! I use it extensively in patrol_cli and love it.

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a version change, per our contributing docs. (I would suggest not deleting the checklist from the PR description in the future, as it covers required steps like that one.)

@bartekpacia

Copy link
Copy Markdown
Member Author

fixed the mistake - my bad, sorry

Comment thread packages/process/CHANGELOG.md Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes

Per the style guide that was linked from the checklist.

Also, nit: we generally put the thing that was worth publishing for first, rather than last.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again, I missed it.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied instead of moved.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏻

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deleted the new, corrected one (which addressed my original comment) instead of the old one.

Comment thread packages/process/CHANGELOG.md Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied instead of moved.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

@bartekpacia Are you still planning on updating this per the comments above?

@bartekpacia

bartekpacia commented Jan 24, 2024 •

Copy link
Copy Markdown
Member Author

@stuartmorgan yes, I just pushed the changes.

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartekpacia bartekpacia added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 25, 2024
@auto-submit
auto-submit Bot merged commit cbe8100 into flutter:main Jan 25, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 26, 2024
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 26, 2024
flutter/packages@21b5abb...cbe8100

2024-01-25 [email protected] Update README of `package:process` (flutter/packages#5475)
2024-01-25 [email protected] Roll Flutter from 19b06f4 to a8efa77 (38 revisions) (flutter/packages#5969)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
This PR fixes flutter/flutter#136221.

BTW it's a great package! I use it extensively in [patrol_cli] and love it.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
This PR fixes flutter/flutter#136221.

BTW it's a great package! I use it extensively in [patrol_cli] and love it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[process] Remove reference to record/replay in README

2 participants