Skip to content

[camera, camera_android] Re-enable passing integration tests - #5658

Merged
auto-submit[bot] merged 57 commits into
flutter:mainfrom
camsim99:test_skipped_cam
Dec 13, 2023
Merged

auto-submit[bot] merged 57 commits into
flutter:mainfrom
camsim99:test_skipped_cam

Conversation

@camsim99

@camsim99 camsim99 commented Dec 12, 2023 •

Copy link
Copy Markdown
Contributor

Re-enables Capture specific image resolutions tests that pass, but were previously failing according to flutter/flutter#93686.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

camsim99 added 30 commits May 1, 2023 16:46
@camsim99
camsim99 marked this pull request as ready for review December 13, 2023 17:20

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 13, 2023
@auto-submit
auto-submit Bot merged commit b5958e2 into flutter:main Dec 13, 2023
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Dec 13, 2023
flutter/packages@80aa46a...b5958e2

2023-12-13 [email protected] [camera, camera_android] Re-enable passing integration tests (flutter/packages#5658)
2023-12-13 [email protected] Roll Flutter from 9719097 to 11a9cb7 (32 revisions) (flutter/packages#5665)
2023-12-13 [email protected] [url_launcher] Return false on Windows when there is no handler (flutter/packages#5359)
2023-12-13 [email protected] [url_launcher] Simplify Linux implementation (flutter/packages#5376)
2023-12-12 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.6.1 to 1.6.2 in /packages/local_auth/local_auth_android/android (flutter/packages#5332)
2023-12-12 [email protected] [pigeon] Adds @CanIgnoreReturnValue annotation (flutter/packages#5601)
2023-12-12 [email protected] [image_picker] updates to resize logic. (flutter/packages#5527)
2023-12-12 [email protected] [various] Update examples using video_player (flutter/packages#5653)
2023-12-12 [email protected] [tools] Validate pubspec topic format (flutter/packages#5565)
2023-12-12 [email protected] [pigeon] Fix Kotlin generator to use provided errorClassName (flutter/packages#5480)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…#5658)

Re-enables `Capture specific image resolutions` tests that pass, but were previously failing according to flutter/flutter#93686.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…#5658)

Re-enables `Capture specific image resolutions` tests that pass, but were previously failing according to flutter/flutter#93686.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants