Skip to content

[go_router] Expose full Uri on GoRouterState in GoRouterRedirect - #5742

Merged
auto-submit[bot] merged 15 commits into
flutter:mainfrom
wwt:Issue103659
Feb 9, 2024
Merged

auto-submit[bot] merged 15 commits into
flutter:mainfrom
wwt:Issue103659

Conversation

@ChopinDavid

Copy link
Copy Markdown
Contributor

A number of developers have voiced the desire to be able to know whether a GoRouterState is the result of a deep-link or in-app navigation from within their GoRouter's redirect method. This can be accomplished by exposing the Uri's scheme and host on the GoRouterState. This way, we can know whether the GoRouterState is the result of a deep-link by checking state.uri.scheme != null or state.uri.host != null.

This PR would close #103659.

No tests were broken as a result of this change, and we have added coverage for this change through new tests.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: go_router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[go_router] Prevent access to route when navigated to via a deep link

7 participants