Repository navigation
[go_router] Expose full Uri on GoRouterState in GoRouterRedirect - #5742
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of developers have voiced the desire to be able to know whether a
GoRouterStateis the result of a deep-link or in-app navigation from within theirGoRouter'sredirectmethod. This can be accomplished by exposing theUri'sschemeandhoston theGoRouterState. This way, we can know whether theGoRouterStateis the result of a deep-link by checkingstate.uri.scheme != nullorstate.uri.host != null.This PR would close #103659.
No tests were broken as a result of this change, and we have added coverage for this change through new tests.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.