Skip to content

Add transitionDuration parameter - #5854

Merged
auto-submit[bot] merged 24 commits into
flutter:mainfrom
GiftShower:duraion-option
Feb 7, 2024
Merged

auto-submit[bot] merged 24 commits into
flutter:mainfrom
GiftShower:duraion-option

Conversation

@GiftShower

Copy link
Copy Markdown
Contributor

Adds transitionDuration parameter for specifying how long the animation should be.

This adds the following suggestion from the issue flutter/flutter#114272

The duration of the animations are set to 1 second, we should have the option to set animation durations when creating slot layouts.

Originally posted by @jamiewest in https://github.com/flutter/flutter/issues/114272#issuecomment-1304288452

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

GiftShower and others added 15 commits March 19, 2023 17:34
Adds `transitionDuration` parameter for specifying how long the animation should be.
- Test if animation ends at declared duration.
fix incorrect versioning
# Conflicts:
#	packages/flutter_adaptive_scaffold/CHANGELOG.md
#	packages/flutter_adaptive_scaffold/pubspec.yaml
# Conflicts:
#	packages/flutter_adaptive_scaffold/CHANGELOG.md
#	packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart
#	packages/flutter_adaptive_scaffold/pubspec.yaml
@GiftShower GiftShower changed the title Duraion option Add transitionDuration parameter Jan 10, 2024
@GiftShower

Copy link
Copy Markdown
Contributor Author

This was previously opened but closed due to CI failure and no edits after draft, so I opened it again.

@GiftShower

Copy link
Copy Markdown
Contributor Author

@stuartmorgan please check macOS RunnerTest. Thanks.

Comment thread packages/flutter_adaptive_scaffold/example/pubspec.yaml Outdated
Comment thread packages/flutter_adaptive_scaffold/example/pubspec.yaml Outdated
@GiftShower
GiftShower marked this pull request as ready for review January 15, 2024 16:53
Comment thread packages/flutter_adaptive_scaffold/example/lib/adaptive_layout_demo.dart Outdated
Comment thread packages/flutter_adaptive_scaffold/example/lib/adaptive_scaffold_demo.dart Outdated
Comment thread packages/flutter_adaptive_scaffold/example/lib/adaptive_layout_demo.dart Outdated
Comment thread packages/flutter_adaptive_scaffold/example/lib/adaptive_scaffold_demo.dart Outdated
Comment thread packages/flutter_adaptive_scaffold/example/test/adaptive_scaffold_demo_test.dart Outdated

@gspencergoog gspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2024
@auto-submit
auto-submit Bot merged commit 396fa75 into flutter:main Feb 7, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 8, 2024
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Feb 8, 2024
flutter/packages@e4ea6bf...29d8cc0

2024-02-07 [email protected] [local_auth] fix: isDeviceSupported on ios (flutter/packages#5125)
2024-02-07 [email protected] [image_picker] Suppress analyzer warning about deprecation of UnmodifiableUint8ListView (flutter/packages#6076)
2024-02-07 [email protected] Add transitionDuration parameter (flutter/packages#5854)
2024-02-07 [email protected] Roll Flutter from e6ba809 to 8431cae (23 revisions) (flutter/packages#6075)
2024-02-07 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Adds support for `setOnScrollPositionChange` for webview_flutter platform implementations (flutter/packages#5664)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Adds transitionDuration parameter for specifying how long the animation should be.

This adds the following suggestion from the issue flutter/flutter#114272

    The duration of the animations are set to 1 second, we should have the option to set animation durations when creating slot layouts.

    Originally posted by @jamiewest in flutter/flutter#114272 (comment)
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Adds transitionDuration parameter for specifying how long the animation should be.

This adds the following suggestion from the issue flutter/flutter#114272

    The duration of the animations are set to 1 second, we should have the option to set animation durations when creating slot layouts.

    Originally posted by @jamiewest in flutter/flutter#114272 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: flutter_adaptive_scaffold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants