Skip to content

Add Kotlin to CONTRIBUTING.md - #5970

Merged
bparrishMines merged 1 commit into
mainfrom
contributing-kotlin
Jan 27, 2024
Merged

bparrishMines merged 1 commit into
mainfrom
contributing-kotlin

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

I never updated the contributing notes about languages when we added Kotlin to the repo.

Include a mention of our Kotlin style and formatter.

@tarrinneal tarrinneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How am I supposed to review this much code?

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 26, 2024
@bparrishMines

Copy link
Copy Markdown
Contributor

tree is actually green, so submitting

@bparrishMines
bparrishMines merged commit 35ac30e into main Jan 27, 2024
@bparrishMines
bparrishMines deleted the contributing-kotlin branch January 27, 2024 03:50
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2024
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 29, 2024
flutter/packages@cbe8100...516648a

2024-01-28 [email protected] [go_router] Add `topRoute` to `GoRouterState` (flutter/packages#5736)
2024-01-27 [email protected] Add Kotlin to CONTRIBUTING.md (flutter/packages#5970)
2024-01-26 [email protected] Roll Flutter (stable) from 67457e6 to 4145645 (1 revision) (flutter/packages#5979)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
I never updated the contributing notes about languages when we added
Kotlin to the repo.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
I never updated the contributing notes about languages when we added
Kotlin to the repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants