Repository navigation
[many] Update example android apps to target SDK level 34. - #7587
Conversation
github-actions
Bot
added
p: camera
p: file_selector
p: flutter_plugin_android_lifecycle
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: local_auth
p: path_provider
p: quick_actions
platform-android
p: webview_flutter
p: video_player
p: url_launcher
p: shared_preferences
labels
|
Instrumentation tests for |
|
This is currently blocked on flutter/flutter#154682 |
I think this pr should land without the camera changes or with a smaller jump in target sdk veriosn and let @camsim99 handle updating the target sdk in flutter/flutter#154682. Please put what testing, if any, did you do besides the automated tests for packages in the pr description. For context there are a lot of subtle, unlikely to be automated, behavior changes from api 28 to 34 and we want to make sure the example apps help people using the plugin. |
For a concrete example I don't think our examples use notifications but a new permission was added that is required to post a notification. So if we used notifications, then code would compile but not work and it is unlikely we would have an automated test for notifications since a permission was not required before. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| ## 0.5.1+8 | ||
|
|
||
| * Updates example app to target SDK 34. |
There was a problem hiding this comment.
I may be wrong about this, but I don't think we need version changes for example app updates @stuartmorgan can you confirm?
There was a problem hiding this comment.
If we get confirmation, I'll update that. In addition, if we do not need version updates, do we also not need CHANGELOG updates?
There was a problem hiding this comment.
We definitely don't need version bumps for this; the CI knows not to flag for that. Since this is a routine change that's not interesting to clients, it doesn't need a changelog either. I think CI will exempt example app build files, but if the CI check complains you can add the label to override the changelog check and re-run that check.
There was a problem hiding this comment.
I'm not sure why right now, but it seems that only flutter_plugin_android_lifecycle is complaining about not having a CHANGELOG change. What/where are you referring to adding an override label?
There was a problem hiding this comment.
He is referring to a github label for the pr named "override: no changelog needed".
There was a problem hiding this comment.
See
for how the label is enforced in code.There was a problem hiding this comment.
@stuartmorgan Do you have any concerns with this PR as it is now?
|
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version Unpublished parts of the example apps appear to not need a version but I dont remember off hand what is published. |
yaakovschectman
added
the
override: no changelog needed
flutter/packages@330581f...df88c81 2024-09-14 [email protected] [webview_flutter] Improve flaky scroll tests (flutter/packages#7621) 2024-09-13 [email protected] Bump deps (flutter/packages#7357) 2024-09-13 [email protected] [flutter_adaptive_scaffold] Use improved MediaQuery methods (flutter/packages#7565) 2024-09-13 [email protected] [many] Update example android apps to target SDK level 34. (flutter/packages#7587) 2024-09-13 [email protected] [pigeon] adds support for non nullable types in collections (flutter/packages#7547) 2024-09-13 [email protected] [flutter_adaptive_scaffold] Adds additional slot animation parameters (flutter/packages#7411) 2024-09-13 [email protected] Roll Flutter from 303f222 to 2d30fe4 (21 revisions) (flutter/packages#7646) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) Bump up target SDK for each Android example app, bump version and changelog, and as necessary export activities and update permissions. For each package, I ensured the example app ran on an emulator before and after the upgrade and compared its behavior, as well as running the integration tests to confirm they pass. flutter/flutter#152929 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [ ] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
) Bump up target SDK for each Android example app, bump version and changelog, and as necessary export activities and update permissions. For each package, I ensured the example app ran on an emulator before and after the upgrade and compared its behavior, as well as running the integration tests to confirm they pass. flutter/flutter#152929 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [ ] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
5 participants
Bump up target SDK for each Android example app, bump version and changelog, and as necessary export activities and update permissions.
For each package, I ensured the example app ran on an emulator before and after the upgrade and compared its behavior, as well as running the integration tests to confirm they pass.
flutter/flutter#152929
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.