Repository navigation
[various] Update Swift plugins for non-nullable generics - #7742
Merged
auto-submit[bot] merged 7 commits intoOct 4, 2024
Merged
Conversation
stuartmorgan-g
requested review from
cbracken,
jmagman and
tarrinneal
as code owners
September 30, 2024 18:38
stuartmorgan-g
commented
Sep 30, 2024
Collaborator
Author
There was a problem hiding this comment.
Since this change is non-obvious: Pigeon used to basically discard the constructor, so none of this mattered. With the update:
- some code failed analysis because it was passing default values, and I decided I preferred having the call site across the Pigeon boundary be very explicit about the settings in each method, and
- the
const SavePanelOptions()didn't compile because const-ness isn't preserved into the Pigeon-generated Dart code.
Contributor
There was a problem hiding this comment.
is const-ness something we'd like?
Collaborator
Author
There was a problem hiding this comment.
Could be worth considering, since having data classes be unmodifiable is often useful. It would add some complexity to native generators though since we'd need to make setters conditionally generated.
Collaborator
Author
|
I can split this into three PRs if folks prefer, I just figured since we get more compiler support for the change with Swift, there aren't too many, and they are relatively small, I'd try batching them. |
stuartmorgan-g
force-pushed
the
pigeon-non-null-update-swift
branch
from
September 30, 2024 18:47
2ccc25f to
2e01a36
Compare
tarrinneal
approved these changes
Oct 4, 2024
tarrinneal
left a comment
tarrinneal
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Did you run into any issues?
Contributor
There was a problem hiding this comment.
is const-ness something we'd like?
Collaborator
Author
I'll let you know once I see whether any regression issues are filed 😅 But it was easy to update. With strongly typed generic enforcement on both sides, the compilers did most of the work for me. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2024
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 4, 2024
flutter/packages@429650f...05bf1d4 2024-10-04 [email protected] [various] Update Swift plugins for non-nullable generics (flutter/packages#7742) 2024-10-04 [email protected] [url_launcher] Update Android Pigeon (flutter/packages#7744) 2024-10-04 [email protected] [xdg_directories] Add `stateHome` property (flutter/packages#7766) 2024-10-03 [email protected] [file_selector] Update Android Pigeon for non-nullable generics (flutter/packages#7781) 2024-10-03 [email protected] [go_router] Relax subroute path requirements (allow root and child routes to have the same path forms ) (flutter/packages#7647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
Updates Swift-based plugins to the current version of Pigeon: - Removes workarounds for previous lack of support for non-nullable generics. - Minor tweaks for other Pigeon changes in intervening versions. These are done as a batch since the Swift plugins are unusual among our plugins in having strong typing changes on the native side, making them easier to do mechanically. Part of flutter/flutter#155891
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
Updates Swift-based plugins to the current version of Pigeon: - Removes workarounds for previous lack of support for non-nullable generics. - Minor tweaks for other Pigeon changes in intervening versions. These are done as a batch since the Swift plugins are unusual among our plugins in having strong typing changes on the native side, making them easier to do mechanically. Part of flutter/flutter#155891
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Swift-based plugins to the current version of Pigeon:
These are done as a batch since the Swift plugins are unusual among our plugins in having strong typing changes on the native side, making them easier to do mechanically.
Part of flutter/flutter#155891
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).