Skip to content

[google_adsense] Tighten exports and docs. - #8233

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
ditman:adsense-prepare-for-h5
Dec 9, 2024
Merged

auto-submit[bot] merged 6 commits into
flutter:mainfrom
ditman:adsense-prepare-for-h5

Conversation

@ditman

@ditman ditman commented Dec 5, 2024 •

Copy link
Copy Markdown
Member
  • Breaking changes: Reshuffles API exports:
    • Removes the adUnit method, and instead exports the AdUnitWidget directly.
    • Renames experimental/google_adsense to experimental/ad_unit_widget.dart.
    • Removes the AdStatus and AdUnitParams exports.
    • Removes the "stub" files, so this package is now web-only and must be used
      through a conditional import.
  • Tweaks several documentation pages to remove references to internal APIs.
  • Splits tests to reflect the new code structure.

Issue

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman
ditman requested a review from sokoloff06 as a code owner December 5, 2024 02:56
@ditman

ditman commented Dec 6, 2024 •

Copy link
Copy Markdown
Member Author

Received feedback to:

  • Remove extension methods, they make the API harder to discover
  • Directly expose the AdUnitWidget
  • Remove the non-web stubs, and make the package web-only

These are good simplifications that should make the package more focused and its code more direct. I'll do them before merging this. Flipping to draft.

@ditman
ditman marked this pull request as draft December 6, 2024 20:59
@ditman
ditman force-pushed the adsense-prepare-for-h5 branch from b7253b2 to 5437423 Compare December 7, 2024 00:06
@ditman
ditman marked this pull request as ready for review December 7, 2024 00:23
Comment thread packages/google_adsense/lib/src/adsense/ad_unit_params.dart Outdated
Fixed typo in Ad Unit dartdocs.

Co-authored-by: Mouad Debbar <[email protected]>
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2024
@auto-submit
auto-submit Bot merged commit 2dc8b98 into flutter:main Dec 9, 2024
@ditman
ditman deleted the adsense-prepare-for-h5 branch December 9, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: google_adsense

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants