Repository navigation
[google_adsense] Tighten exports and docs. - #8233
Merged
Merged
Conversation
Member
Author
|
Received feedback to:
These are good simplifications that should make the package more focused and its code more direct. I'll do them before merging this. Flipping to draft. |
ditman
marked this pull request as draft
December 6, 2024 20:59
ditman
force-pushed
the
adsense-prepare-for-h5
branch
from
December 7, 2024 00:06
b7253b2 to
5437423
Compare
ditman
marked this pull request as ready for review
December 7, 2024 00:23
mdebbar
approved these changes
Dec 9, 2024
Fixed typo in Ad Unit dartdocs. Co-authored-by: Mouad Debbar <[email protected]>
11 tasks done
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adUnitmethod, and instead exports theAdUnitWidgetdirectly.experimental/google_adsensetoexperimental/ad_unit_widget.dart.AdStatusandAdUnitParamsexports.through a conditional import.
Issue
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.