Skip to content

[video_player] Fixes mechanism to detect identifier in multiline WebVTT captions - #8555

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
Gustl22:subtitles
Feb 21, 2025
Merged

auto-submit[bot] merged 6 commits into
flutter:mainfrom
Gustl22:subtitles

Conversation

@Gustl22

@Gustl22 Gustl22 commented Feb 3, 2025 •

Copy link
Copy Markdown
Contributor

In order to play WebVTT captions which include multiple lines the detection must be changed, as captions don't necessarily have an identifier, when they are longer than two lines.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@tarrinneal tarrinneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the version will need to change in the pubspec file as well.

Comment thread packages/video_player/video_player/CHANGELOG.md Outdated
@Gustl22 Gustl22 changed the title [video_player] Fix mechanism to detect identifier in multiline WebVTT captions [video_player] Fixes mechanism to detect identifier in multiline WebVTT captions Feb 5, 2025
@Gustl22
Gustl22 requested a review from tarrinneal February 5, 2025 16:10

@tarrinneal tarrinneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, @stuartmorgan for second review

## 2.9.3

* Updates minimum supported SDK version to Flutter 3.22/Dart 3.4.
* Fixes mechanism to detect identifier in multiline WebVTT captions.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: multi-line

Comment on lines +169 to +170
— It will perforate your stomach.
— You could die.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting choice

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copied it from the test above 😅

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2025
@auto-submit
auto-submit Bot merged commit a135dc6 into flutter:main Feb 21, 2025
@Gustl22
Gustl22 deleted the subtitles branch February 21, 2025 21:30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 24, 2025
github-merge-queue Bot pushed a commit to flutter/flutter that referenced this pull request Feb 24, 2025
flutter/packages@5a721da...5498d4d

2025-02-21 [email protected] Redistribute iOS
plugin owners (flutter/packages#8664)
2025-02-21 [email protected] [video_player] Fixes mechanism to detect
identifier in multiline WebVTT captions (flutter/packages#8555)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
…TT captions (flutter#8555)

In order to play WebVTT captions which include multiple lines the detection must be changed, as captions don't necessarily have an identifier, when they are longer than two lines.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
…TT captions (flutter#8555)

In order to play WebVTT captions which include multiple lines the detection must be changed, as captions don't necessarily have an identifier, when they are longer than two lines.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…TT captions (flutter#8555)

In order to play WebVTT captions which include multiple lines the detection must be changed, as captions don't necessarily have an identifier, when they are longer than two lines.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…TT captions (flutter#8555)

In order to play WebVTT captions which include multiple lines the detection must be changed, as captions don't necessarily have an identifier, when they are longer than two lines.
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Oct 12, 2026
A cue was treated as having an identifier whenever it had more than two
lines, so a multi-line cue without an identifier used its first text
line as the timing line and was dropped. Detect the identifier by
checking whether the first line is the timing line instead.

This package's WebVTT parser was copied from upstream video_player,
which has the same code and fixed it the same way in video_player 2.9.3:
flutter/packages#8555
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Oct 12, 2026
A cue was treated as having an identifier whenever it had more than two
lines, so a multi-line cue without an identifier used its first text
line as the timing line and was dropped. Detect the identifier by
checking whether the first line is the timing line instead.

This package's WebVTT parser was copied from upstream video_player,
which has the same code and fixed it the same way in video_player 2.9.3:
flutter/packages#8555
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Oct 12, 2026
A cue was treated as having an identifier whenever it had more than two
lines, so a multi-line cue without an identifier used its first text
line as the timing line and was dropped. Detect the identifier by
checking whether the first line is the timing line instead.

This package's WebVTT parser was copied from upstream video_player,
which has the same code and fixed it the same way in video_player 2.9.3:
flutter/packages#8555
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Oct 12, 2026
A cue was treated as having an identifier whenever it had more than two
lines, so a multi-line cue without an identifier used its first text
line as the timing line and was dropped. Detect the identifier by
checking whether the first line is the timing line instead.

This package's WebVTT parser was copied from upstream video_player,
which has the same code and fixed it the same way in video_player 2.9.3:
flutter/packages#8555
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Oct 12, 2026
A cue was treated as having an identifier whenever it had more than two
lines, so a multi-line cue without an identifier used its first text
line as the timing line and was dropped. Detect the identifier by
checking whether the first line is the timing line instead.

This package's WebVTT parser was copied from upstream video_player,
which has the same code and fixed it the same way in video_player 2.9.3:
flutter/packages#8555
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Oct 12, 2026
A cue was treated as having an identifier whenever it had more than two
lines, so a multi-line cue without an identifier used its first text
line as the timing line and was dropped. Detect the identifier by
checking whether the first line is the timing line instead.

This package's WebVTT parser was copied from upstream video_player,
which has the same code and fixed it the same way in video_player 2.9.3:
flutter/packages#8555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: video_player

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants