Repository navigation
[camera_avfoundation] Implementation swift migration - part 3.5 - #9254
Merged
auto-submit[bot] merged 2 commits intoMay 28, 2025
Conversation
11 tasks done
RobertOdrowaz
force-pushed
the
feature/camera-implementation-swift-migration-part3-5
branch
from
May 23, 2025 09:50
8696776 to
933ccf3
Compare
Contributor
Author
|
@hellohuanlin Please take a look at this when you have some time |
Contributor
Sorry i was on leave last week. Will take a look first thing after the holiday break. |
hellohuanlin
approved these changes
May 28, 2025
RobertOdrowaz
force-pushed
the
feature/camera-implementation-swift-migration-part3-5
branch
from
May 28, 2025 15:01
933ccf3 to
d659f6e
Compare
RobertOdrowaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2025
github-merge-queue Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 29, 2025
flutter/packages@5743798...4463066 2025-05-29 [email protected] Allow tests to use macOS 14 or 15.5 (flutter/packages#9328) 2025-05-29 [email protected] [camera_web] Remove mocktail dependency. (flutter/packages#9195) 2025-05-28 [email protected] Roll Flutter from 4372bfb to 0e536eb (27 revisions) (flutter/packages#9334) 2025-05-28 [email protected] [camera_avfoundation] Implementation swift migration - part 3.5 (flutter/packages#9254) 2025-05-28 [email protected] [webview_flutter_wkwebview] Fix `testNilRequest` test for macOS 15.5 (flutter/packages#9330) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…ter#9254) Migrates camera implementation as part of flutter/flutter#119109 This PR consists of everything that was possible to extract from the [part 4](flutter#9219) which includes: * Adds `audioCaptureDeviceFactory` to `FLTCamConfiguration`. * Renames the `lockCaptureOrientation` method of Objective-C type `FLTCam` when exported to Swift. * Renames arguments of the `captureOutput` method of Objective-C type `FLTCam` when exported to Swift. * Changes the `connection` argument type of the `captureOutput` method of the of `FLTCam` class to `AVCaptureConnection`. * Makes `minimum/maximumAvailableZoomFactor` and `minimum/maximumExposureOffset` fields of `FLTCam` readonly. * Remove `@testable` from `camera_avfoundation_objc` imports ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…ter#9254) Migrates camera implementation as part of flutter/flutter#119109 This PR consists of everything that was possible to extract from the [part 4](flutter#9219) which includes: * Adds `audioCaptureDeviceFactory` to `FLTCamConfiguration`. * Renames the `lockCaptureOrientation` method of Objective-C type `FLTCam` when exported to Swift. * Renames arguments of the `captureOutput` method of Objective-C type `FLTCam` when exported to Swift. * Changes the `connection` argument type of the `captureOutput` method of the of `FLTCam` class to `AVCaptureConnection`. * Makes `minimum/maximumAvailableZoomFactor` and `minimum/maximumExposureOffset` fields of `FLTCam` readonly. * Remove `@testable` from `camera_avfoundation_objc` imports ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…ter#9254) Migrates camera implementation as part of flutter/flutter#119109 This PR consists of everything that was possible to extract from the [part 4](flutter#9219) which includes: * Adds `audioCaptureDeviceFactory` to `FLTCamConfiguration`. * Renames the `lockCaptureOrientation` method of Objective-C type `FLTCam` when exported to Swift. * Renames arguments of the `captureOutput` method of Objective-C type `FLTCam` when exported to Swift. * Changes the `connection` argument type of the `captureOutput` method of the of `FLTCam` class to `AVCaptureConnection`. * Makes `minimum/maximumAvailableZoomFactor` and `minimum/maximumExposureOffset` fields of `FLTCam` readonly. * Remove `@testable` from `camera_avfoundation_objc` imports ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…ter#9254) Migrates camera implementation as part of flutter/flutter#119109 This PR consists of everything that was possible to extract from the [part 4](flutter#9219) which includes: * Adds `audioCaptureDeviceFactory` to `FLTCamConfiguration`. * Renames the `lockCaptureOrientation` method of Objective-C type `FLTCam` when exported to Swift. * Renames arguments of the `captureOutput` method of Objective-C type `FLTCam` when exported to Swift. * Changes the `connection` argument type of the `captureOutput` method of the of `FLTCam` class to `AVCaptureConnection`. * Makes `minimum/maximumAvailableZoomFactor` and `minimum/maximumExposureOffset` fields of `FLTCam` readonly. * Remove `@testable` from `camera_avfoundation_objc` imports ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Nakiha
pushed a commit
to Nakiha/VoidPlayer-Flutter
that referenced
this pull request
Sep 28, 2026
flutter/packages@5743798...4463066 2025-05-29 [email protected] Allow tests to use macOS 14 or 15.5 (flutter/packages#9328) 2025-05-29 [email protected] [camera_web] Remove mocktail dependency. (flutter/packages#9195) 2025-05-28 [email protected] Roll Flutter from 1bd82e3 to 8b03f41 (27 revisions) (flutter/packages#9334) 2025-05-28 [email protected] [camera_avfoundation] Implementation swift migration - part 3.5 (flutter/packages#9254) 2025-05-28 [email protected] [webview_flutter_wkwebview] Fix `testNilRequest` test for macOS 15.5 (flutter/packages#9330) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates camera implementation as part of flutter/flutter#119109
This PR consists of everything that was possible to extract from the part 4 which includes:
audioCaptureDeviceFactorytoFLTCamConfiguration.lockCaptureOrientationmethod of Objective-C typeFLTCamwhen exported to Swift.captureOutputmethod of Objective-C typeFLTCamwhen exported to Swift.connectionargument type of thecaptureOutputmethod of the ofFLTCamclass toAVCaptureConnection.minimum/maximumAvailableZoomFactorandminimum/maximumExposureOffsetfields ofFLTCamreadonly.@testablefromcamera_avfoundation_objcimportsPre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3