Repository navigation
[camera_avfoundation] Implementation swift migration - part 5 - #9397
Merged
auto-submit[bot] merged 4 commits intoJun 20, 2025
Merged
auto-submit[bot] merged 4 commits into
auto-submit[bot] merged 4 commits into
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
RobertOdrowaz
marked this pull request as draft
June 6, 2025 08:48
RobertOdrowaz
changed the title
RobertOdrowaz
force-pushed
the
feature/camera-implementation-swift-migration-part5
branch
from
June 6, 2025 09:04
8f8fa48 to
8cfe0f2
Compare
RobertOdrowaz
marked this pull request as ready for review
June 6, 2025 09:05
hellohuanlin
approved these changes
Jun 9, 2025
Contributor
Author
|
This PR falls under the "refactors with no semantic change (e.g. null safety migrations)" test exemption. It's a part of the migration from ObjC to Swift so by design it's covered by the existing tests |
Contributor
|
@RobertOdrowaz Please request an exemption in Discord channel. |
Collaborator
|
test-exempt: code refactor with no semantic change |
…, setExposurePoint, setFocusMode, and setFocusPoint to Swift
RobertOdrowaz
force-pushed
the
feature/camera-implementation-swift-migration-part5
branch
from
June 20, 2025 12:32
1f66770 to
470ae33
Compare
RobertOdrowaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 20, 2025
github-merge-queue Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 20, 2025
flutter/packages@0ec4053...7f41e75 2025-06-20 [email protected] [camera_avfoundation] Implementation swift migration - part 5 (flutter/packages#9397) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…r#9397) Migrates camera implementation as part of flutter/flutter#119109 This PR migrates a part of `FLTCam` class to Swift. This PR includes the second chunk: - `start` - `stop` - `close` - `receivedImageStreamData` - `reportInitializationState` - `setExposureMode` - `setExposureOffset` - `setExposurePoint` - `setFocusMode` - `setFocusPoint` Some properties of the `FLTCam` have to be temporarily made public so that they are accessible in `DefaultCamera`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
flutter/packages@0ec4053...7f41e75 2025-06-20 [email protected] [camera_avfoundation] Implementation swift migration - part 5 (flutter/packages#9397) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…r#9397) Migrates camera implementation as part of flutter/flutter#119109 This PR migrates a part of `FLTCam` class to Swift. This PR includes the second chunk: - `start` - `stop` - `close` - `receivedImageStreamData` - `reportInitializationState` - `setExposureMode` - `setExposureOffset` - `setExposurePoint` - `setFocusMode` - `setFocusPoint` Some properties of the `FLTCam` have to be temporarily made public so that they are accessible in `DefaultCamera`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#9397) Migrates camera implementation as part of flutter/flutter#119109 This PR migrates a part of `FLTCam` class to Swift. This PR includes the second chunk: - `start` - `stop` - `close` - `receivedImageStreamData` - `reportInitializationState` - `setExposureMode` - `setExposureOffset` - `setExposurePoint` - `setFocusMode` - `setFocusPoint` Some properties of the `FLTCam` have to be temporarily made public so that they are accessible in `DefaultCamera`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…r#9397) Migrates camera implementation as part of flutter/flutter#119109 This PR migrates a part of `FLTCam` class to Swift. This PR includes the second chunk: - `start` - `stop` - `close` - `receivedImageStreamData` - `reportInitializationState` - `setExposureMode` - `setExposureOffset` - `setExposurePoint` - `setFocusMode` - `setFocusPoint` Some properties of the `FLTCam` have to be temporarily made public so that they are accessible in `DefaultCamera`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Nakiha
pushed a commit
to Nakiha/VoidPlayer-Flutter
that referenced
this pull request
Sep 28, 2026
flutter/packages@0ec4053...7f41e75 2025-06-20 [email protected] [camera_avfoundation] Implementation swift migration - part 5 (flutter/packages#9397) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates a part of
FLTCamclass to Swift.This PR includes the second chunk:
startstopclosereceivedImageStreamDatareportInitializationStatesetExposureModesetExposureOffsetsetExposurePointsetFocusModesetFocusPointSome properties of the
FLTCamhave to be temporarily made public so that they are accessible inDefaultCamera.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3