Skip to content

[go_router] Fix routing to treat URLs with different cases (e.g., /Home vs /home) as distinct routes. - #9426

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
ValentinVignal:go-router/support-routes-with-different-case
Jun 24, 2025
Merged

auto-submit[bot] merged 6 commits into
flutter:mainfrom
ValentinVignal:go-router/support-routes-with-different-case

Conversation

@ValentinVignal

Copy link
Copy Markdown
Contributor

Fixes flutter/flutter#169809

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3

@ValentinVignal

Copy link
Copy Markdown
Contributor Author

There is now a failing test for go_router_builder. Can I update it in this PR? If not, how should we tackle this?

@chunhtai

Copy link
Copy Markdown
Contributor

you will have to disable the test first and do a 3 phase transition, for disable and enabling the test I think you can use noversion and changlog exception

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ValentinVignal

Copy link
Copy Markdown
Contributor Author

Fair enough! I've created the PR to skip the test in go_router_builder: #9444

auto-submit Bot pushed a commit that referenced this pull request Jun 23, 2025
Part of  flutter/flutter#169809

Prepare for #9426, this skips a test that needs to migrated with the new version of `go_router`.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
@ValentinVignal ValentinVignal added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2025
@auto-submit
auto-submit Bot merged commit d848b16 into flutter:main Jun 24, 2025
@ValentinVignal

Copy link
Copy Markdown
Contributor Author

PR to unskipt the test #9482

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2025
github-merge-queue Bot pushed a commit to flutter/flutter that referenced this pull request Jun 24, 2025
flutter/packages@02770da...d9d3191

2025-06-24 [email protected] [google_sign_in] Redesign API for
current identity SDKs (flutter/packages#9267)
2025-06-24 [email protected] [go_router]
Fix routing to treat URLs with different cases (e.g., `/Home` vs
`/home`) as distinct routes. (flutter/packages#9426)
2025-06-23 [email protected] [google_sign_in] Redesign API for
current identity SDKs - Platform Implementations (flutter/packages#9479)
2025-06-23 [email protected] Roll Flutter from
0ab008a to d733bea (16 revisions) (flutter/packages#9478)
2025-06-23 [email protected]
[go_router_builder] Skip case sensitive test (flutter/packages#9444)
2025-06-23 [email protected] [google_sign_in] Redesign API for
current identity SDKs - Platform Interface (flutter/packages#9454)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
Part of  flutter/flutter#169809

Prepare for flutter#9426, this skips a test that needs to migrated with the new version of `go_router`.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…ome` vs `/home`) as distinct routes. (flutter#9426)

Fixes flutter/flutter#169809

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
auto-submit Bot pushed a commit that referenced this pull request Jul 10, 2025
…9482)

Part of
- flutter/flutter#169809

Follow-up of 
- #9426
- #9444

Unskips and migrates the test about case sensitivity to the new version of `go_router` 15.2.4.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
flutter/packages@02770da...d9d3191

2025-06-24 [email protected] [google_sign_in] Redesign API for
current identity SDKs (flutter/packages#9267)
2025-06-24 [email protected] [go_router]
Fix routing to treat URLs with different cases (e.g., `/Home` vs
`/home`) as distinct routes. (flutter/packages#9426)
2025-06-23 [email protected] [google_sign_in] Redesign API for
current identity SDKs - Platform Implementations (flutter/packages#9479)
2025-06-23 [email protected] Roll Flutter from
0ab008a to d733bea (16 revisions) (flutter/packages#9478)
2025-06-23 [email protected]
[go_router_builder] Skip case sensitive test (flutter/packages#9444)
2025-06-23 [email protected] [google_sign_in] Redesign API for
current identity SDKs - Platform Interface (flutter/packages#9454)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
Part of  flutter/flutter#169809

Prepare for flutter#9426, this skips a test that needs to migrated with the new version of `go_router`.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…ome` vs `/home`) as distinct routes. (flutter#9426)

Fixes flutter/flutter#169809

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…lutter#9482)

Part of
- flutter/flutter#169809

Follow-up of 
- flutter#9426
- flutter#9444

Unskips and migrates the test about case sensitivity to the new version of `go_router` 15.2.4.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Part of  flutter/flutter#169809

Prepare for flutter#9426, this skips a test that needs to migrated with the new version of `go_router`.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…ome` vs `/home`) as distinct routes. (flutter#9426)

Fixes flutter/flutter#169809

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…lutter#9482)

Part of
- flutter/flutter#169809

Follow-up of 
- flutter#9426
- flutter#9444

Unskips and migrates the test about case sensitivity to the new version of `go_router` 15.2.4.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Part of  flutter/flutter#169809

Prepare for flutter#9426, this skips a test that needs to migrated with the new version of `go_router`.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…ome` vs `/home`) as distinct routes. (flutter#9426)

Fixes flutter/flutter#169809

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…lutter#9482)

Part of
- flutter/flutter#169809

Follow-up of 
- flutter#9426
- flutter#9444

Unskips and migrates the test about case sensitivity to the new version of `go_router` 15.2.4.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Nakiha pushed a commit to Nakiha/VoidPlayer-Flutter that referenced this pull request Sep 28, 2026
flutter/packages@02770da...d9d3191

2025-06-24 [email protected] [google_sign_in] Redesign API for
current identity SDKs (flutter/packages#9267)
2025-06-24 [email protected] [go_router]
Fix routing to treat URLs with different cases (e.g., `/Home` vs
`/home`) as distinct routes. (flutter/packages#9426)
2025-06-23 [email protected] [google_sign_in] Redesign API for
current identity SDKs - Platform Implementations (flutter/packages#9479)
2025-06-23 [email protected] Roll Flutter from
b369148 to 85130cb (16 revisions) (flutter/packages#9478)
2025-06-23 [email protected]
[go_router_builder] Skip case sensitive test (flutter/packages#9444)
2025-06-23 [email protected] [google_sign_in] Redesign API for
current identity SDKs - Platform Interface (flutter/packages#9454)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: go_router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[go_router] Doesn't support "/abc", "/ABC" as two different paths

3 participants