Repository navigation
Re-enable rfw tests - #415
Conversation
dc201c0 to
3ec489c
Compare
|
I don't think this can land until the failing presubmits are addressed. |
|
Looking into the failing tests. |
3ec489c to
4ce9328
Compare
|
Could the workflow be run please? To see if the failure is still happening. |
|
@victoreronmosele Could you resolve the merge conflicts? If you push a new commit that will also rerun all the tests. Thank you! |
|
@goderbauer I'll get on it. |
b740197 to
fc04645
Compare
fc04645 to
fff8db8
Compare
|
Hi @goderbauer, I'm seeing a "Merge is not an allowed merge method in this repository." message after pushing the commit. Do I still need to do anything else? |
No, I just need to find a secondary reviewer and then we should be able to land this. |
|
LGTM! We'll need to update the pinned version in flutter/flutter after this lands |
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Actually, sorry, double checking... shouldn't the commit here be updated to include the change from flutter/packages#7148 that fixed this?
It looks like that change landed at
3890ceef72e140bc30cdeca59e0c70721f476fba
but this file checks out
0891835f8341b5c7bcd9d035a8d9c6b0f0039034
|
@Piinks the change was made in the packages repo. Is there a way to include it here? |
|
Yes, the file you are renaming specifies which commit from flutter/packages to checkout. :) |
|
Thanks! Will update the file. |
|
Updated the commit in the file. |
|
NB after this lands the flutter/tests commit needs to be manually rolled into flutter/flutter. |
|
Made a PR for the manual roll here. |
This roll enables `rfw` tests in `customer_testing`. See flutter/tests#415 <!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
5 participants
This PR re-enables the
rfwtests disabled in #386.The
rfwtests were fixed in flutter/packages#7148.Closes flutter/flutter#151659.