Repository navigation
Disable the assorted_layout_widgets tests - #502
Conversation
They are failing when trying to deprecate material_ui and cupertino_ui in flutter/flutter#192957. I already successfully migrated the package, but some failures seem to remain. They should be fixed and then these tests should be re-enabled.
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, is the test owner notified by this? our policy says 72 hours waiting time before removed the registry entirely
|
The owner @marcglasberg was notified in marcglasberg/assorted_layout_widgets#42 about 48 hours ago, and has been nothing but helpful and prompt ❤️ . I'm nervous about missing the release cutoff though, so I'm going to go ahead and merge this. I hope that's ok @marcglasberg. I will continue with trying to fix the failure in assorted_layout_widgets and getting the tests re-enabled. |
|
Hey @justinmc , the failing run used |
|
Yes I forgot to update tests.version when I accused assorted_layout_widgets of failing, apologies! I've reenabled it in my PR (flutter/flutter#192957) and CI is currently running. If that goes green then I'll revert the disable in the flutter/tests repo. |
It was my mistake to disable these in #502 after missing a hash update on my flutter/flutter PR flutter/flutter#192957. These tests work correctly and pass after migration and should be enabled. FYI @marcglasberg
3 participants
They are failing when trying to deprecate material_ui and cupertino_ui in flutter/flutter#192957. I already successfully migrated the package, but some failures seem to remain. They should be fixed and then these tests should be re-enabled.