Repository navigation
Migration guide for ButtonBar deprecation - #10325
Merged
Merged
Conversation
TahaTesser
requested review from
MaryaBelanger,
atsansone,
domesticmouse,
parlough and
sfshaza2
as code owners
March 21, 2024 13:27
Collaborator
|
Visit the preview URL for this PR (updated for commit 126773c): https://flutter-docs-prod--pr10325-deprecate-button-bar-guide-pjphz43b.web.app |
domesticmouse
approved these changes
Mar 21, 2024
Piinks
reviewed
Mar 22, 2024
Piinks
left a comment
Piinks
left a comment
Contributor
There was a problem hiding this comment.
Ack, let's not merge until the PR lands in the framework. I had a left-field question about possibly refactoring ButtonBar.
parlough
marked this pull request as draft
March 25, 2024 20:17
TahaTesser
marked this pull request as ready for review
April 1, 2024 11:45
Contributor
Author
|
Marked this as ready to review since flutter/flutter#145523 landed. |
Piinks
reviewed
Apr 2, 2024
sfshaza2
approved these changes
Apr 2, 2024
sfshaza2
left a comment
sfshaza2
left a comment
Contributor
There was a problem hiding this comment.
lgtm. Thanks, @TahaTesser!
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Apr 5, 2024
Related to flutter/flutter#145523 ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to flutter/flutter#145523
Presubmit checklist