Skip to content

document default flavor - #10642

Merged
sfshaza2 merged 2 commits into
flutter:mainfrom
holzgeist:fix-document-default-flavor
May 22, 2024
Merged

sfshaza2 merged 2 commits into
flutter:mainfrom
holzgeist:fix-document-default-flavor

Conversation

@holzgeist

Copy link
Copy Markdown
Contributor

Description of what this PR is changing or adding, and why:

Document new feature (setting default flavor in pubspec.yaml) introduced in flutter/flutter#147968

This is a new version of #10632, please only merge once the PR above is released

Issues fixed by this PR (if any):

flutter/flutter#22856

Presubmit checklist

@domesticmouse domesticmouse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @sfshaza2

@domesticmouse

Copy link
Copy Markdown
Contributor

/gcbrun

@flutter-website-bot

Copy link
Copy Markdown
Collaborator

Visit the preview URL for this PR (updated for commit a3d0f73):

https://flutter-docs-prod--pr10642-fix-document-default-flavor-0sd3nmya.web.app

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2
sfshaza2 merged commit 4e72d2a into flutter:main May 22, 2024
@holzgeist
holzgeist deleted the fix-document-default-flavor branch May 22, 2024 11:15
andrewkolos added a commit that referenced this pull request May 22, 2024
parlough pushed a commit that referenced this pull request May 22, 2024
…able on stable (#10646)

Reverts #10642.

This is a similar story to
#10641. TL;DR a contributor
merged a new feature into the master branch of flutter/flutter and also
kindly drafted a website change to document this feature. However, this
change shouldn't have been merged until the feature is actually
available on the stable channel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants