Skip to content

Declare package:flutter_gen to be deprecated - #11343

Merged
matanlurey merged 4 commits into
flutter:mainfrom
matanlurey:breaking-change-generate-i10n
Oct 31, 2024
Merged

matanlurey merged 4 commits into
flutter:mainfrom
matanlurey:breaking-change-generate-i10n

Conversation

@matanlurey

Copy link
Copy Markdown
Contributor

Declare the package:flutter_gen approach deprecated and explain the current migration path.

Part of flutter/flutter#157819, flutter/flutter#102983.

/cc @andrewkolos

@matanlurey
matanlurey requested review from a team, parlough and sfshaza2 as code owners October 30, 2024 17:37
@matanlurey matanlurey changed the title Add a breaking change. Declare package:flutter_gen to be deprecated Oct 30, 2024

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/content/release/breaking-changes/flutter-generate-i10n-source.md Outdated
Comment thread src/content/release/breaking-changes/flutter-generate-i10n-source.md Outdated

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Oct 31, 2024
…157879)

Work towards #157819. **No behavior changes as a result of this PR**.

Based on a proof of concept by @jonahwilliams (#157818).

The existence of this flag (which for the time being, defaults to `true`) implies the following:

1. The (legacy, deprecated) `.flutter-plugins` file is not generated:
    https://docs.flutter.dev/release/breaking-changes/flutter-plugins-configuration
    
2. The (legacy, deprecated) `package:flutter_gen` is not synthetically generated:
    flutter/website#11343
    (awaiting website approvers, but owners approve this change)

This change creates `useImplicitPubspecResolution` and plumbs it through as a required variable, parsing it from a `FlutterCommand.globalResults` where able. In tests, I've defaulted the value to `true` 100% of the time - except for places where the value itself is acted on directly, in which case there are true and false test-cases (e.g. localization and i10n based classes and functions).

I'm not extremely happy this needed to change 50+ files, but is sort of a result of how inter-connected many of the elements of the tools are. I believe keeping this as an explicit (flagged) argument will be our best way to ensure the default behavior changes consistently and that tests are running as expected.
@matanlurey
matanlurey merged commit 6fbd62f into flutter:main Oct 31, 2024
@matanlurey
matanlurey deleted the breaking-change-generate-i10n branch October 31, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants