Skip to content

Keep quotes when minifying HTML attributes - #11904

Merged
sfshaza2 merged 1 commit into
mainfrom
fix/quotes-to-attributes
Apr 15, 2025
Merged

sfshaza2 merged 1 commit into
mainfrom
fix/quotes-to-attributes

Conversation

@parlough

Copy link
Copy Markdown
Member

99d9296 switched to a different HTML minifier which stripped quotes from HTML attributes when technically browsers could parse it, but generally shouldn't be dropped.

@parlough
parlough requested review from a team, antfitch and sfshaza2 as code owners April 15, 2025 16:45
@flutter-website-bot

Copy link
Copy Markdown
Collaborator

Visit the preview URL for this PR (updated for commit dde24c0):

https://flutter-docs-prod--pr11904-fix-quotes-to-attributes-3sz3btgh.web.app

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2

Copy link
Copy Markdown
Contributor

cc @bkonyi

@sfshaza2
sfshaza2 merged commit 53881c1 into main Apr 15, 2025
@sfshaza2
sfshaza2 deleted the fix/quotes-to-attributes branch April 15, 2025 17:06
kenzieschmoll added a commit to flutter/tests that referenced this pull request Apr 17, 2025
Reverts #452 now that
flutter/website#11904 has landed and updates the
DevTools hash to include a skipped test
(flutter/devtools#9150) that was hitting the
network against the [test
guidelines](https://github.com/flutter/tests?tab=readme-ov-file#adding-more-tests).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants