Skip to content

Scribble text input client breaking change - #6679

Merged
sfshaza2 merged 5 commits into
flutter:mainfrom
fbcouch:scribble-text-input-client
Jan 19, 2022
Merged

sfshaza2 merged 5 commits into
flutter:mainfrom
fbcouch:scribble-text-input-client

Conversation

@fbcouch

@fbcouch fbcouch commented Jan 13, 2022 •

Copy link
Copy Markdown
Contributor

Description of what this PR is changing or adding, and why:

This adds a migration guide for the new members of TextInputClient added by flutter/flutter#75472

Issues fixed by this PR (if any):

Presubmit checklist

@khanhnwin

Copy link
Copy Markdown
Contributor

Hey @fbcouch! Thanks for this PR. LGTM! @sfshaza2 can you PTAL and confirm?

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, @fbcouch. LGTM!

@sfshaza2

Copy link
Copy Markdown
Contributor

Ah, there is one thing you need to do, @fbcouch. Can you add this item to the index file?

@fbcouch

fbcouch commented Jan 14, 2022

Copy link
Copy Markdown
Contributor Author

@sfshaza2 Done!

@domesticmouse

Copy link
Copy Markdown
Contributor

@sfshaza2 is https://github.com/flutter/website/blob/main/src/_data/sidenav.yml the index file you are referring to?

@sfshaza2

Copy link
Copy Markdown
Contributor

@sfshaza2 is https://github.com/flutter/website/blob/main/src/_data/sidenav.yml the index file you are referring to?

No, @domesticmouse, this PR is doing the correct thing. It would really bloat our sidenav if we listed breaking changes there.

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2
sfshaza2 merged commit 04ec578 into flutter:main Jan 19, 2022
AlexV525 pushed a commit to AlexV525/flutter-website that referenced this pull request Mar 26, 2022
* Create scribble-text-input-client.md

* Update scribble-text-input-client.md

* Update scribble-text-input-client.md

* Update scribble-text-input-client.md

* Update index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants