Repository navigation
Scan directory for all asset files - #992
Merged
Merged
Conversation
Updates doc to reflect changes on flutter/flutter#16413
googlebot
added
the
cla: yes
Contributor
Author
|
Pls don't merge yet, needs to merge code at flutter/flutter repo first |
Contributor
|
LGTM |
Contributor
Author
|
@Sfshaza a couple of notes:
If this will get reverted until it beta rolls it out I can tackle the edits in one go. However if this PR doesn't get reverted I can make a fix for it but I'll probably take 36h from now to get started, after I start it should done shortly. |
fmatosqg
added a commit
to fmatosqg/website
that referenced
this pull request
May 31, 2018
follow up from flutter#992 - Change variant examples to filenames and paths supported by the tools today - explicitly mentions no support for subfolder scanning (except variants) - explicitly mentions it's ok to skip the main asset and add file for variants I may be missing something but I can't remember `dark` being a valid variant according to either the `asset.dart` from build time or `painting.dart` (?) from run time. If it is we may have a bug in either/both build and runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates doc to reflect changes on flutter/flutter#16413