Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

rename stub_ui to web_ui - #10776

Merged
yjbanov merged 2 commits into
flutter-team-archive:masterfrom
yjbanov:rename-stub-to-web
Aug 9, 2019
Merged

yjbanov merged 2 commits into
flutter-team-archive:masterfrom
yjbanov:rename-stub-to-web

Conversation

@yjbanov

@yjbanov yjbanov commented Aug 8, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Licenses aren't happy, otherwise

LGTM!

@yjbanov

yjbanov commented Aug 9, 2019

Copy link
Copy Markdown
Contributor Author

Weird. I expressly ran the license script, and it didn't complain locally. I'll look into it.

@jonahwilliams

Copy link
Copy Markdown
Contributor

This does still work on master, correct?

@yjbanov

yjbanov commented Aug 9, 2019

Copy link
Copy Markdown
Contributor Author

Looks like I was fooled by the "no change in signature" messages, thinking nothing changed, while the script still produced new files. I hope I fixed it this time.

@yjbanov
yjbanov merged commit 708fc62 into flutter-team-archive:master Aug 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2019
This was referenced Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants