This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
Avoid accessing the Cocoa view on the GPU or IO task runners. - #13295
Merged
chinmaygarde merged 1 commit intoOct 22, 2019
Merged
Conversation
The view was being accessed from a background thread so its OpenGL context could be accessed. This tripped thread safety assertions in Cocoa. Now the OpenGL context is stashed in the FlutterEngine instance itself.
gaaclarke
approved these changes
Oct 22, 2019
gaaclarke
left a comment
gaaclarke
left a comment
Contributor
There was a problem hiding this comment.
Can we add thread asserts in some of these methods?
Contributor
Author
|
Cocoa already does this for us. That's how I found the same. |
franciscojma86
approved these changes
Oct 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2019
This was referenced Oct 23, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 23, 2019
[email protected]:flutter/engine.git/compare/a064063e3f63...b5a33d4 git log a064063..b5a33d4 --no-merges --oneline 2019-10-23 [email protected] Allow embedders to update preferrred locales. (flutter-team-archive/engine#13238) 2019-10-23 [email protected] Show strace logs when the Fuchsia gen_package script gets an error from the packaging tool (flutter-team-archive/engine#13298) 2019-10-22 [email protected] [web] Cupertino dynamic color fix. (flutter-team-archive/engine#13296) 2019-10-22 [email protected] Roll src/third_party/dart 6a65ea9cad..4ab09db0f4 (2 commits) 2019-10-22 [email protected] Update harfbuzz to 2.6.2, Roll buildroot to a518e (flutter-team-archive/engine#13242) 2019-10-22 [email protected] Fix decode feature detection in HtmlCodec (flutter-team-archive/engine#13274) 2019-10-22 [email protected] Avoid accessing the Cocoa view on the GPU or IO task runners. (flutter-team-archive/engine#13295) 2019-10-22 [email protected] Make flutter_tester support multithreaded testing, and run all Dart tests in both single and multithreaded configurations (flutter-team-archive/engine#13273) 2019-10-22 [email protected] Made restarting the Engine remember the last entrypoint that was used. (flutter-team-archive/engine#13289) 2019-10-22 [email protected] Roll src/third_party/skia f3f8ac37e468..2638f3d44b02 (12 commits) (flutter-team-archive/engine#13291) 2019-10-22 [email protected] Flesh out the CanvasKit backend some more (flutter-team-archive/engine#13275) 2019-10-22 [email protected] Roll Dart to 6a65ea9cad4b014f88d2f1be1b321db493725a1c. (flutter-team-archive/engine#13294) 2019-10-22 [email protected] Disable flaky test ShellTest_ReportTimingsIsCalled. (flutter-team-archive/engine#13292) 2019-10-22 [email protected] Do not request executable permission on Fuchsia file mappings unless it is required (flutter-team-archive/engine#13290) 2019-10-22 [email protected] Roll src/third_party/dart e1c409792c..5814319bf9 (9 commits) 2019-10-22 [email protected] Revert "Made restarting the Engine remember the last entrypoint that was used. (#13264)" (flutter-team-archive/engine#13287) 2019-10-22 [email protected] Made restarting the Engine remember the last entrypoint that was used. (flutter-team-archive/engine#13264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/a064063e3f63...b5a33d4 git log a064063..b5a33d4 --no-merges --oneline 2019-10-23 [email protected] Allow embedders to update preferrred locales. (flutter-team-archive/engine#13238) 2019-10-23 [email protected] Show strace logs when the Fuchsia gen_package script gets an error from the packaging tool (flutter-team-archive/engine#13298) 2019-10-22 [email protected] [web] Cupertino dynamic color fix. (flutter-team-archive/engine#13296) 2019-10-22 [email protected] Roll src/third_party/dart 6a65ea9cad..4ab09db0f4 (2 commits) 2019-10-22 [email protected] Update harfbuzz to 2.6.2, Roll buildroot to a518e (flutter-team-archive/engine#13242) 2019-10-22 [email protected] Fix decode feature detection in HtmlCodec (flutter-team-archive/engine#13274) 2019-10-22 [email protected] Avoid accessing the Cocoa view on the GPU or IO task runners. (flutter-team-archive/engine#13295) 2019-10-22 [email protected] Make flutter_tester support multithreaded testing, and run all Dart tests in both single and multithreaded configurations (flutter-team-archive/engine#13273) 2019-10-22 [email protected] Made restarting the Engine remember the last entrypoint that was used. (flutter-team-archive/engine#13289) 2019-10-22 [email protected] Roll src/third_party/skia f3f8ac37e468..2638f3d44b02 (12 commits) (flutter-team-archive/engine#13291) 2019-10-22 [email protected] Flesh out the CanvasKit backend some more (flutter-team-archive/engine#13275) 2019-10-22 [email protected] Roll Dart to 6a65ea9cad4b014f88d2f1be1b321db493725a1c. (flutter-team-archive/engine#13294) 2019-10-22 [email protected] Disable flaky test ShellTest_ReportTimingsIsCalled. (flutter-team-archive/engine#13292) 2019-10-22 [email protected] Do not request executable permission on Fuchsia file mappings unless it is required (flutter-team-archive/engine#13290) 2019-10-22 [email protected] Roll src/third_party/dart e1c409792c..5814319bf9 (9 commits) 2019-10-22 [email protected] Revert "Made restarting the Engine remember the last entrypoint that was used. (flutter#13264)" (flutter-team-archive/engine#13287) 2019-10-22 [email protected] Made restarting the Engine remember the last entrypoint that was used. (flutter-team-archive/engine#13264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The view was being accessed from a background thread so its OpenGL context could be accessed. This tripped thread safety assertions in Cocoa. Now the OpenGL context is stashed in the FlutterEngine instance itself.