Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Build engine artifacts when cross-compiling for macOS - #25804

Merged
knopp merged 1 commit into
flutter-team-archive:masterfrom
knopp:macos_engine_artifacts
Apr 29, 2021
Merged

Build engine artifacts when cross-compiling for macOS#25804
knopp merged 1 commit into
flutter-team-archive:masterfrom
knopp:macos_engine_artifacts

Conversation

@knopp

@knopp knopp commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

flutter/flutter#69221

This is necessary to get dart, flutter_tester and other artifacts available when cross-compiling to M1

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla Bot added the cla: yes label Apr 28, 2021
@knopp
knopp force-pushed the macos_engine_artifacts branch from 9ff2534 to c7c1440 Compare April 28, 2021 09:44
@knopp
knopp requested a review from cbracken April 28, 2021 15:00
cbracken
cbracken approved these changes Apr 29, 2021
View reviewed changes

@cbracken cbracken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@knopp
knopp merged commit 10de8f4 into flutter-team-archive:master Apr 29, 2021
@knopp
knopp deleted the macos_engine_artifacts branch April 29, 2021 17:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 29, 2021
@engine-flutter-autoroll
10de8f4 Build engine artifacts when cross-compiling for macOS (flutte…
16b78f0 
…r-team-archive/engine#25804)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2021
@engine-flutter-autoroll
10de8f4 Build engine artifacts when cross-compiling for macOS (flutte…
6511e85 
…r-team-archive/engine#25804)
gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request May 5, 2021
@knopp @gspencergoog
Build engine artifacts when cross-compiling for macOS (flutter-team-a…
d6824fd 
…rchive#25804)

flutter/flutter#69221
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@cbracken cbracken cbracken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@knopp @cbracken