Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web:canvaskit] test zero font size - #37916

Merged
auto-submit[bot] merged 2 commits into
flutter-team-archive:mainfrom
yjbanov:test-zero-font-size
Dec 6, 2022
Merged

[web:canvaskit] test zero font size#37916
auto-submit[bot] merged 2 commits into
flutter-team-archive:mainfrom
yjbanov:test-zero-font-size

Conversation

@yjbanov

@yjbanov yjbanov commented Nov 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Triaging flutter/flutter#93257 I couldn't reproduce the issue. It looks like zero font size was fixed. I couldn't find a test for it, so adding a test in this PR.

@flutter-dashboard flutter-dashboard Bot added the platform-web Code specifically for the web engine label Nov 26, 2022
@yjbanov yjbanov mentioned this pull request Nov 26, 2022
Open
@ditman

ditman commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

@yjbanov I think you closed the wrong issue with this PR?

harryterkelsen
harryterkelsen approved these changes Dec 1, 2022
View reviewed changes

@harryterkelsen harryterkelsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjbanov

yjbanov commented Dec 4, 2022

Copy link
Copy Markdown
Contributor Author

@yjbanov I think you closed the wrong issue with this PR?

Whoops! Fixed.

@yjbanov
yjbanov force-pushed the test-zero-font-size branch from 28e2a30 to 727ebbb Compare December 4, 2022 00:02
@yjbanov yjbanov mentioned this pull request Dec 4, 2022
Closed
@flutter-dashboard

flutter-dashboard Bot commented Dec 4, 2022

Copy link
Copy Markdown

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #37916 at sha 727ebbb

@yjbanov
yjbanov force-pushed the test-zero-font-size branch from 727ebbb to 7ca1965 Compare December 6, 2022 00:24
@skia-gold

skia-gold commented Dec 6, 2022

Copy link
Copy Markdown

Gold has detected about 2 new digest(s) on patchset 1.
View them at https://flutter-engine-gold.skia.org/cl/github/37916

@flutter-dashboard

flutter-dashboard Bot commented Dec 6, 2022

Copy link
Copy Markdown

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #37916 at sha 7ca1965

@yjbanov yjbanov mentioned this pull request Dec 6, 2022
Closed
@skia-gold

skia-gold commented Dec 6, 2022

Copy link
Copy Markdown

Gold has detected about 2 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/37916

@flutter-dashboard

flutter-dashboard Bot commented Dec 6, 2022

Copy link
Copy Markdown

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #37916 at sha a9ca8b2

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2022
@auto-submit
auto-submit Bot merged commit 9554754 into flutter-team-archive:main Dec 6, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 6, 2022
@engine-flutter-autoroll
9554754 [web:canvaskit] test zero font size (flutter-team-archive/eng…
7b2c5f0 
…ine#37916)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 6, 2022
@engine-flutter-autoroll
9554754 [web:canvaskit] test zero font size (flutter-team-archive/eng…
beca1f1 
…ine#37916)
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Dec 6, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 4ff8cc3 to 4f22c27 (3 revisions) (#116620)
676229f 
* 143977b Roll Skia from b63a254727f3 to 13e5241ce8b7 (6 revisions) (flutter-team-archive/engine#38106)

* 9554754 [web:canvaskit] test zero font size (flutter-team-archive/engine#37916)

* 4f22c27 Roll Skia from 13e5241ce8b7 to aea62b0970c3 (2 revisions) (flutter-team-archive/engine#38107)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Flutter Engine from 4ff8cc3 to 4f22c27 (3 revisions) (flutter#11…
0a15cd8 
…6620)

* 143977b Roll Skia from b63a254727f3 to 13e5241ce8b7 (6 revisions) (flutter-team-archive/engine#38106)

* 9554754 [web:canvaskit] test zero font size (flutter-team-archive/engine#37916)

* 4f22c27 Roll Skia from 13e5241ce8b7 to aea62b0970c3 (2 revisions) (flutter-team-archive/engine#38107)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from 4ff8cc3 to 4f22c27 (3 revisions) (flutter#11…
9fe2ddc 
…6620)

* 143977b Roll Skia from b63a254727f3 to 13e5241ce8b7 (6 revisions) (flutter-team-archive/engine#38106)

* 9554754 [web:canvaskit] test zero font size (flutter-team-archive/engine#37916)

* 4f22c27 Roll Skia from 13e5241ce8b7 to aea62b0970c3 (2 revisions) (flutter-team-archive/engine#38107)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@harryterkelsen harryterkelsen harryterkelsen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine will affect goldens

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yjbanov @ditman @skia-gold @harryterkelsen @mdebbar