Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Download EMSDK for host builders to build wasm_release - #38013

Merged
harryterkelsen merged 1 commit into
flutter-team-archive:mainfrom
harryterkelsen:wasm-release-engine
Dec 2, 2022
Merged

harryterkelsen merged 1 commit into
flutter-team-archive:mainfrom
harryterkelsen:wasm-release-engine

Conversation

@harryterkelsen

Copy link
Copy Markdown
Contributor

Downloads EMSDK for the host builders.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@harryterkelsen

harryterkelsen commented Dec 1, 2022 •

Copy link
Copy Markdown
Contributor Author

This is to enable building wasm_release on the host builders so we can bundle CanvasKit with flutter_web_sdk.

See https://flutter-review.git.corp.google.com/c/recipes/+/36801

@harryterkelsen
harryterkelsen merged commit 6bbf3e0 into flutter-team-archive:main Dec 2, 2022
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Dec 2, 2022
* 74c9430 Roll Skia from c432cb7480b5 to 28c1bbab82b8 (2 revisions) (flutter-team-archive/engine#38033)

* 6bbf3e0 Download EMSDK for host builders to build wasm_release (flutter-team-archive/engine#38013)
mit-mit pushed a commit to mit-mit/flutter that referenced this pull request Dec 6, 2022
…6432)

* 74c9430 Roll Skia from c432cb7480b5 to 28c1bbab82b8 (2 revisions) (flutter-team-archive/engine#38033)

* 6bbf3e0 Download EMSDK for host builders to build wasm_release (flutter-team-archive/engine#38013)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…6432)

* 74c9430 Roll Skia from c432cb7480b5 to 28c1bbab82b8 (2 revisions) (flutter-team-archive/engine#38033)

* 6bbf3e0 Download EMSDK for host builders to build wasm_release (flutter-team-archive/engine#38013)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…6432)

* 74c9430 Roll Skia from c432cb7480b5 to 28c1bbab82b8 (2 revisions) (flutter-team-archive/engine#38033)

* 6bbf3e0 Download EMSDK for host builders to build wasm_release (flutter-team-archive/engine#38013)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants