This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
Don't rely on timings for dimension_provider unit test. - #39343
Merged
auto-submit[bot] merged 1 commit intoFeb 2, 2023
Merged
auto-submit[bot] merged 1 commit into
auto-submit[bot] merged 1 commit into
Conversation
ditman
approved these changes
Feb 2, 2023
ditman
left a comment
ditman
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for removing test flakiness!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2023
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 2, 2023
* 510ecfa Don't rely on timings for dimension_provider unit test. (flutter-team-archive/engine#39343) * b1ccae7 Roll Skia from 60242c4ea6a7 to c2d81db3ef41 (5 revisions) (flutter-team-archive/engine#39344) * 616ecd8 [Web][HTML] Add mirrored characters support for RTL languages (flutter-team-archive/engine#39162)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes flutter/flutter#119757