Repository navigation
[Impeller] Sample the gaussian function once per texture sample - #40949
Conversation
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM.
I have seen the rippling, but thats in both the before and after versions. But my change assumes that we were sampling the from the center before. Should we just back that out entirely?
|
Yeah just like with the text UV mapping, I don't think we were doing it properly to begin with. I tested out before/after your change and it doesn't seem to make the problem any worse than it already was, so I think we should keep it. |
|
SGTM, ship it |
chinmaygarde
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 40949, due to - The status or check suite Linux Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Continued drop in GPU utilization from this patch: |
3 participants
Follow-up to remove the second gaussian sample, which isn't really improving quality.
For both before and after, I don't think we're sampling from the center of texels, and this is causing textures with high frequency info to "ripple" a bit when slowly increasing the blur radius (another issue might be that our texture downsizing is, again, too aggressive too early). I'm currently working out the best way to fix this and may follow-up with something.