Repository navigation
Roll vulkan-deps and vs_toolchain - #41455
Conversation
|
@loic-sharma the windows failure looks like a flake (see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8782914159211749409/+/u/build_host_debug_arm64_flutter_build_archives:artifacts_flutter_build_archives:embedder_flutter_tools_font-subset_flutter_build_archives:dart_sdk_archive_flutter_shell_platform_windows_client_wrapper:client_wrapper_archive_flutter_build_archives:windows_flutter/stdout for example). Is this being tracked? Or did rolling ANGLE actually break this somehow? |
|
Hm I don't think I've seen that error before, and I couldn't find an issue tracking that error. I'm not sure if it's a flake or a new issue from your roll. Let me know if you'd like me to try building your changes on my Windows machine. |
Needed for flutter-team-archive/engine#41455 Our current VS Toolchain does not have the ARM64 artifacts in its windows SDK. This rolls to the latest one used in Chromium, with a link.
|
Needs https://flutter-review.googlesource.com/c/recipes/+/42462. I'm trying to figure out why Linux Unopt sometimes gives LSAN/ASAN errors. |
|
Rolling ANGLE to that revision is causing one of the embedder unittests to hang. I'm going to hold off on that for now and just do vulkan-deps/vs_toolchain |
dnfield
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 41455, due to - The status or check suite Linux License has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dnfield
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 41455, due to - The status or check suite Linux License has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dnfield
added
the
autosubmit
|
auto label is removed for flutter/engine, pr: 41455, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
Bot
removed
the
autosubmit
dnfield
added
the
autosubmit
flutter-team-archive/engine@7b385ab...706c023 2023-04-26 [email protected] Roll vulkan-deps and vs_toolchain (flutter-team-archive/engine#41455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Rolls vulkan-deps to https://chromium.googlesource.com/vulkan-deps/+/40b75117a60b11c42a1fb87bf14c0f49bcdb8b3d