Repository navigation
[web] Cleanup touch and mouse event adapters - #43697
Conversation
There was a problem hiding this comment.
From what I can find, this drops support for: iPhone 6 and lower (5S, etc...) (those are stuck forever in iOS 12).
The oldest model that we'd support would be: iPhone 6S (iOS 15.7), released in September, 2018 2015.
Should we deploy an app with this change applied so we can take a look at it with a bunch of devices?
| if (_defaultSupportDetector.hasPointerEvents) { | ||
| event = createDomPointerEvent('pointermove'); | ||
| } else if (_defaultSupportDetector.hasTouchEvents) { | ||
| event = createDomTouchEvent('touchcancel'); |
There was a problem hiding this comment.
createDomTouchEvent and createDomMouseEvent are now probably unused in dom.dart?
There was a problem hiding this comment.
createDomTouchEvent yes, but createDomMouseEvent is used in other places.
| PointerBinding( | ||
| this.flutterViewElement, | ||
| this._keyboardConverter, [ | ||
| this._detector = const PointerSupportDetector(), |
There was a problem hiding this comment.
I don't think we need this PointerSupportDetector anymore?
There was a problem hiding this comment.
This was (and still is) useful for testing
Bummer 😞 maybe we should wait a little longer? |
I'm gathering some data about usage, maybe we can extract some guideline to know when something can be deprecated :P |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
(Approving because I didn't have other than nits)
mdebbar
added
the
autosubmit
flutter-team-archive/engine@046ec85...77b952f 2023-11-13 [email protected] [web] Cleanup touch and mouse event adapters (flutter-team-archive/engine#43697) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
This PR cleans up a big source of complexity in our pointer handling code. It also drops support for Safari versions prior to 13 (caniuse).
Right now, we throw a hard error when running in a browser that doesn't support
PointerEvents. Should we turn it into a soft warning, and just disable gesture/pointer handling on those browsers?For users who need to support older versions of Safari, they can try this polyfill: https://github.com/wessberg/pointer-events (thanks @ditman!)
Fixes flutter/flutter#116141