Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix the rules for determining whether a blur image filter is valid - #43791

Merged
auto-submit[bot] merged 1 commit into
flutter-team-archive:mainfrom
jason-simmons:bug_130318_b
Jul 19, 2023
Merged

auto-submit[bot] merged 1 commit into
flutter-team-archive:mainfrom
jason-simmons:bug_130318_b

Conversation

@jason-simmons

Copy link
Copy Markdown
Contributor

@jason-simmons
jason-simmons requested a review from flar July 18, 2023 22:06

@flar flar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions...

Comment thread display_list/effects/dl_image_filter.h
Comment thread display_list/effects/dl_image_filter_unittests.cc
Comment thread display_list/effects/dl_image_filter.h Outdated

@flar flar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2023
@auto-submit
auto-submit Bot merged commit ea484fe into flutter-team-archive:main Jul 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2023
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jul 19, 2023
flutter-team-archive/engine@0293a7c...09389b1

2023-07-19 [email protected] Roll ANGLE from b32d661389a6 to 255dec886475 (1 revision) (flutter-team-archive/engine#43804)
2023-07-19 [email protected] Fix the rules for determining whether a blur image filter is valid (flutter-team-archive/engine#43791)
2023-07-19 [email protected] Roll Skia from 035b12a03918 to c03050eb2b65 (1 revision) (flutter-team-archive/engine#43802)
2023-07-19 [email protected] Roll Skia from 9062ca6a691c to 035b12a03918 (3 revisions) (flutter-team-archive/engine#43801)
2023-07-19 [email protected] Roll Fuchsia Mac SDK from SCshjyIlymHWD9W4D... to Iqf3gYJ8Vkq8k8l3O... (flutter-team-archive/engine#43800)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from SCshjyIlymHW to Iqf3gYJ8Vkq8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
…0867)

flutter-team-archive/engine@0293a7c...09389b1

2023-07-19 [email protected] Roll ANGLE from b32d661389a6 to 255dec886475 (1 revision) (flutter-team-archive/engine#43804)
2023-07-19 [email protected] Fix the rules for determining whether a blur image filter is valid (flutter-team-archive/engine#43791)
2023-07-19 [email protected] Roll Skia from 035b12a03918 to c03050eb2b65 (1 revision) (flutter-team-archive/engine#43802)
2023-07-19 [email protected] Roll Skia from 9062ca6a691c to 035b12a03918 (3 revisions) (flutter-team-archive/engine#43801)
2023-07-19 [email protected] Roll Fuchsia Mac SDK from SCshjyIlymHWD9W4D... to Iqf3gYJ8Vkq8k8l3O... (flutter-team-archive/engine#43800)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from SCshjyIlymHW to Iqf3gYJ8Vkq8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Development

Successfully merging this pull request may close these issues.

2 participants