This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
[Windows] Expose channel buffers 'resize' and 'overflow' control commands exposed by the control channel. - #47158
Merged
auto-submit[bot] merged 6 commits intoDec 14, 2023
Conversation
loic-sharma
reviewed
Oct 26, 2023
loic-sharma
reviewed
Oct 26, 2023
loic-sharma
reviewed
Oct 26, 2023
loic-sharma
reviewed
Oct 26, 2023
bleroux
force-pushed
the
windows_add_channel_buffer_helpers_resize_and_overflow
branch
from
November 2, 2023 13:20
5eb2181 to
d7510bf
Compare
stuartmorgan-g
suggested changes
Nov 2, 2023
bleroux
force-pushed
the
windows_add_channel_buffer_helpers_resize_and_overflow
branch
8 times, most recently
from
November 9, 2023 14:46
9782c71 to
69e56a1
Compare
bleroux
commented
Nov 9, 2023
chinmaygarde
changed the title
chinmaygarde
changed the title
stuartmorgan-g
suggested changes
Nov 10, 2023
bleroux
force-pushed
the
windows_add_channel_buffer_helpers_resize_and_overflow
branch
from
November 13, 2023 15:11
26cb681 to
c0e81b2
Compare
Contributor
|
Friendly ping @stuartmorgan it looks like this needs another review. |
stuartmorgan-g
suggested changes
Nov 30, 2023
2 tasks done
Contributor
Author
|
Thanks for the feedback. I will pursue this work in two weeks (I won't have access to my Windows setup until December 11th). |
bleroux
force-pushed
the
windows_add_channel_buffer_helpers_resize_and_overflow
branch
from
December 12, 2023 08:56
c0e81b2 to
0c1609b
Compare
stuartmorgan-g
suggested changes
Dec 13, 2023
|
|
||
| static constexpr char kControlChannelName[] = "dev.flutter/channel-buffers"; | ||
| static constexpr char kResizeMethod[] = "resize"; | ||
| static constexpr char kOverflowMethod[] = "overflow"; |
Contributor
There was a problem hiding this comment.
These three lines should be in an anonymous namespace (and thus don't need static to have internal linkage), rather than the internal namespace, since they don't need to be referenced outside of this file.
| // Adjusts the number of messages that will get buffered when sending messages | ||
| // to channels that aren't fully set up yet. For example, the engine isn't | ||
| // running yet or the channel's message handler isn't set up on the Dart side | ||
| // yet. |
Contributor
There was a problem hiding this comment.
Here and below: per the style guide, declaration comments belong at the declaration point (which is the header), not the definition point. That's true even for things that not intended for general use, like internal-namespaced functions or private class methods.
| namespace flutter { | ||
|
|
||
| namespace internal { | ||
| // Internal helpers functions used by BasicMessageChannel and MethodChannel. |
bleroux
force-pushed
the
windows_add_channel_buffer_helpers_resize_and_overflow
branch
2 times, most recently
from
December 14, 2023 09:10
1ed71eb to
c6e9fe9
Compare
bleroux
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2023
…rol commands exposed by the control channel. (flutter-team-archive/engine#47158)
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 14, 2023
flutter-team-archive/engine@caf3327...a565cea 2023-12-14 [email protected] [Windows] Expose channel buffers 'resize' and 'overflow' control commands exposed by the control channel. (flutter-team-archive/engine#47158) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bleroux
deleted the
windows_add_channel_buffer_helpers_resize_and_overflow
branch
December 15, 2023 20:35
Closed
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two helper functions to invoke the 'resize' and 'overflow' commands exposed by the control channel.
See:
https://github.com/flutter/engine/blob/93e8901490e78c7ba7e319cce4470d9c6478c6dc/lib/ui/channel_buffers.dart#L302-L309
Implementation based on the discussion from #46998.
Related Issue
Windows implementation for flutter/flutter#132386
Tests
Adds 4 tests.