This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
Add trace events for creating minikin fonts - #8477
Merged
Merged
Conversation
Creating fonts can take a long time (50ms+) during frame build in the UI thread. Trace them to help us understand when it's causing a jank.
cbracken
approved these changes
Apr 8, 2019
cbracken
left a comment
cbracken
left a comment
Contributor
There was a problem hiding this comment.
But you'll want to run clang-format on this.
chinmaygarde
reviewed
Apr 8, 2019
| std::shared_ptr<minikin::FontFamily> FontCollection::CreateMinikinFontFamily( | ||
| const sk_sp<SkFontMgr>& manager, | ||
| const std::string& family_name) { | ||
| TRACE_EVENT0("flutter", "FontCollection::CreateMinikinFontFamily"); |
Contributor
There was a problem hiding this comment.
Use the varargs variant FML_TRACE_EVENT to log the family name as well.
Contributor
Author
There was a problem hiding this comment.
How about the TRACE_EVENT1 in the new patch?
chinmaygarde
reviewed
Apr 8, 2019
| minikin_fonts.emplace_back(std::move(minikin_font)); | ||
| } | ||
|
|
||
| TRACE_EVENT1("flutter", "minikin::FontFamily", |
Contributor
There was a problem hiding this comment.
I think a trace counter makes more sense here.
Contributor
Author
There was a problem hiding this comment.
I tried that in my first version and it's a little confusing to me because it no longer appears in the UI thread. Instead, if has its own grey box on the very top (similar to CPU/GPU clock counters). Is there a way to trace a counter, but show that as a normal box in the UI thread?
chinmaygarde
approved these changes
Apr 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2019
This was referenced Apr 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 9, 2019
flutter-team-archive/engine@6a0460c...eec74e5 git log 6a0460c..eec74e5 --no-merges --oneline eec74e5 Rename the blink namespace to flutter. (flutter-team-archive/engine#8517) fff80a0 Roll src/third_party/dart 06ed3f598c..06ed3f598c (0 commits) 000f8e3 Remove dart_utf_tag from DEPS 9bfa96d Add trace events for creating minikin fonts (flutter-team-archive/engine#8477) 5381e57 Roll src/third_party/skia 9a7c7be15969..b5d8c634f95b (11 commits) (flutter-team-archive/engine#8513) df707c6 switch to newer APIs for shaders and filters (flutter-team-archive/engine#8511) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating fonts can take a long time (50ms+) during frame build in the UI
thread. Trace them to help us understand when it's causing a jank.
For example:
