Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Mark iOS arm64 simulators as unsupported - #4209

Merged
fluttergithubbot merged 4 commits into
flutter-team-archive:masterfrom
jmagman:gm-excluded
Aug 3, 2021
Merged

[google_maps_flutter] Mark iOS arm64 simulators as unsupported#4209
fluttergithubbot merged 4 commits into
flutter-team-archive:masterfrom
jmagman:gm-excluded

Conversation

@jmagman

@jmagman jmagman commented Jul 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Before flutter/flutter#87244, any app using the google_maps_flutter plugin would not build on an M1 Mac.

Replace deprecated 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' with 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'arm64'.

Fixes flutter/flutter#87242
See also #4208

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@jmagman
jmagman requested a review from cyanglaz as a code owner July 30, 2021 18:36
@jmagman jmagman self-assigned this Jul 30, 2021
@google-cla google-cla Bot added the cla: yes label Jul 30, 2021
@jmagman jmagman mentioned this pull request Jul 30, 2021
Merged
11 tasks done
jmagman
jmagman commented Jul 30, 2021
View reviewed changes
Comment thread packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md Outdated
@jmagman

jmagman commented Jul 30, 2021

Copy link
Copy Markdown
Contributor Author

Test failure to be fixed in flutter/flutter: flutter/flutter#87362

@jmagman
jmagman requested a review from stuartmorgan-g August 2, 2021 19:15
stuartmorgan-g
stuartmorgan-g approved these changes Aug 2, 2021
View reviewed changes

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with version nit.

Comment thread packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md Outdated
@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 2, 2021
@fluttergithubbot

fluttergithubbot commented Aug 2, 2021

Copy link
Copy Markdown

This pull request is not suitable for automatic merging in its current state.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 2, 2021
@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 3, 2021
@fluttergithubbot
fluttergithubbot merged commit 1fc3d92 into flutter-team-archive:master Aug 3, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2021
@engine-flutter-autoroll
1fc3d92 [google_maps_flutter] Mark iOS arm64 simulators as unsupported (
a17736a 
flutter-team-archive/plugins#4209)
@jmagman
jmagman deleted the gm-excluded branch August 3, 2021 20:20
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@jmagman @fotiDim
[google_maps_flutter] Mark iOS arm64 simulators as unsupported (flutt…
9ee8716 
…er-team-archive#4209)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@jmagman @amantoux
[google_maps_flutter] Mark iOS arm64 simulators as unsupported (flutt…
6affee1 
…er-team-archive#4209)
@jmagman jmagman mentioned this pull request Dec 1, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz
1 more reviewer
@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

cla: yes p: google_maps_flutter platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mark google_maps_flutter as not supporting arm64 iOS simulators

3 participants

@jmagman @fluttergithubbot @stuartmorgan-g