Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Change google-services.json and GoogleService-Info.plist of example - #859

Merged
bparrishMines merged 8 commits into
flutter-team-archive:masterfrom
bparrishMines:new_services
Nov 8, 2018
Merged

bparrishMines merged 8 commits into
flutter-team-archive:masterfrom
bparrishMines:new_services

Conversation

@bparrishMines

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread packages/google_sign_in/example/android/app/google-services.json

@kroikie kroikie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are changing the project for the Android example, you should do the same for the iOS example.

@mehmetf

mehmetf commented Oct 17, 2018

Copy link
Copy Markdown
Contributor

Does firebase_auth need to be changed to follow suit? It depends on this plugin.

@kroikie

kroikie commented Oct 17, 2018

Copy link
Copy Markdown
Contributor

This is mainly a change to the example, the plugin itself should not be affected. We may want to do a similar change to the firebase_auth example plugin if we have issues with the Firebase project that example uses.


dependencies {
classpath 'com.android.tools.build:gradle:3.1.2'
classpath 'com.android.tools.build:gradle:3.2.0'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
classpath 'com.android.tools.build:gradle:3.2.0'
classpath 'com.android.tools.build:gradle:3.2.1'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the plugins are at 3.2.0 and we try to keep them at the same version. So I think 3.2.0 will be the version until we update them all again. Same for the suggestion below.


dependencies {
classpath 'com.android.tools.build:gradle:3.1.2'
classpath 'com.android.tools.build:gradle:3.2.0'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
classpath 'com.android.tools.build:gradle:3.2.0'
classpath 'com.android.tools.build:gradle:3.2.1'

@mehmetf

mehmetf commented Oct 18, 2018

Copy link
Copy Markdown
Contributor

Any blockers for this?

@bparrishMines

Copy link
Copy Markdown
Contributor Author

@mehmetf Yes, I'm trying to update the iOS plist too, but I'm running into errors.

@bparrishMines bparrishMines changed the title Update gradle and google-services.json Change google-services.json and GoogleService-Info.plist of example Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants