Support for relative imports to reuse step impls by kunalvishwasrao · Pull Request #360 · getgauge/gauge-python

kunalvishwasrao · 2024-06-26T21:39:12Z

Added support to reuse the step implementations from a different project using relative imports #359

Hey @chadlwilson, @bugdiver,
It would be really great if you could review this pull request and help me with the approval of pending workflow checks for merging this PR.

Thanks!😄

Added support to reuse the step implementations from a different project using relative imports #359 Signed-off-by: Kunal Vishwasrao <[email protected]>

chadlwilson · 2024-06-27T13:46:54Z

Personally I don’t have enough knowledge or time to review/validate this, especially without automated tests for all the paths. This does seem quite convoluted to me though, and potentially creating a lot of opportunity for issues in weird cases.

Signed-off-by: Kunal Vishwasrao <[email protected]>

bugdiver · 2024-06-27T15:03:05Z

@zabil @kunalvishwasrao Can we also try to move the logic to append the path from _import_file, since it will try to update the path for every file import and the path will have duplicate values. Perhaps we can try to update the path in _import_impl or load_impls?

kunalvishwasrao · 2024-06-27T15:07:30Z

@zabil @kunalvishwasrao Can we also try to move the logic to append the path from _import_file, since it will try to update the path for every file import and the path will have duplicate values. Perhaps we can try to update the path in _import_impl or load_impls?

@bugdiver, sure sounds good, will update that.

Signed-off-by: Kunal Vishwasrao <[email protected]>

kunalvishwasrao

Hey @zabil, @bugdiver,

Moved the sys path appending into load_impls method as suggested.

Thanks

gaugebot · 2024-07-01T05:06:10Z

@kunalvishwasrao Thank you for contributing to gauge-python. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

Signed-off-by: Kunal Vishwasrao <[email protected]>

kunalvishwasrao

Hey @bugdiver,

Thanks for approving the PR. I've bumped up the gauge-python version too. Can you please let me know if its ready to be merged?

Thanks!😄

…-imports

…on to getgauge#360) Signed-off-by: Kunal Vishwasrao <[email protected]>

* Bump the pip-dependencies group with 2 updates (#358) Bumps the pip-dependencies group with 2 updates: [importlib-metadata](https://github.com/python/importlib_metadata) and [setuptools](https://github.com/pypa/setuptools). Updates `importlib-metadata` from 7.1.0 to 7.2.1 - [Release notes](https://github.com/python/importlib_metadata/releases) - [Changelog](https://github.com/python/importlib_metadata/blob/main/NEWS.rst) - [Commits](python/importlib_metadata@v7.1.0...v7.2.1) Updates `setuptools` from 70.0.0 to 70.1.0 - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v70.0.0...v70.1.0) --- updated-dependencies: - dependency-name: importlib-metadata dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pip-dependencies - dependency-name: setuptools dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pip-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Kunal Vishwasrao <[email protected]> * Bump the pip-dependencies group across 1 directory with 3 updates (#362) Bumps the pip-dependencies group with 3 updates in the / directory: [debugpy](https://github.com/microsoft/debugpy), [importlib-metadata](https://github.com/python/importlib_metadata) and [setuptools](https://github.com/pypa/setuptools). Updates `debugpy` from 1.8.1 to 1.8.2 - [Release notes](https://github.com/microsoft/debugpy/releases) - [Commits](microsoft/debugpy@v1.8.1...v1.8.2) Updates `importlib-metadata` from 7.2.1 to 8.0.0 - [Release notes](https://github.com/python/importlib_metadata/releases) - [Changelog](https://github.com/python/importlib_metadata/blob/main/NEWS.rst) - [Commits](python/importlib_metadata@v7.2.1...v8.0.0) Updates `setuptools` from 70.1.0 to 70.1.1 - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v70.1.0...v70.1.1) --- updated-dependencies: - dependency-name: debugpy dependency-type: direct:production update-type: version-update:semver-patch dependency-group: pip-dependencies - dependency-name: importlib-metadata dependency-type: direct:production update-type: version-update:semver-major dependency-group: pip-dependencies - dependency-name: setuptools dependency-type: direct:production update-type: version-update:semver-patch dependency-group: pip-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Kunal Vishwasrao <[email protected]> * Support for relative imports to reuse step impls Signed-off-by: Kunal Vishwasrao <[email protected]> * Update release dependencies Signed-off-by: BugDiver <[email protected]> Signed-off-by: Kunal Vishwasrao <[email protected]> * Correctly loading the methods from relatively imported classs (addition to #360) Signed-off-by: Kunal Vishwasrao <[email protected]> * Update getgauge/impl_loader.py Correctly loading the methods from relatively imported classes (#365) Signed-off-by: Kunal Vishwasrao <[email protected]> Co-authored-by: Zabil Cheriya Maliackal <[email protected]> Signed-off-by: Kunal Vishwasrao <[email protected]> * Returning method_list in update_step_resgistry_with_class method (#365) Signed-off-by: Kunal Vishwasrao <[email protected]> * Adding test class for relative import unittest (#365) Signed-off-by: Kunal Vishwasrao <[email protected]> * Adding unittest for relative import (#365) Signed-off-by: Kunal Vishwasrao <[email protected]> * Renaming method to update_step_registry_with_class (#365) Signed-off-by: Kunal Vishwasrao <[email protected]> * Updating unittest for impl loader (#365) Signed-off-by: Kunal Vishwasrao <[email protected]> * Bumping up python package version (#365) Signed-off-by: Kunal Vishwasrao <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Kunal Vishwasrao <[email protected]> Signed-off-by: BugDiver <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vinay Shukla <[email protected]> Co-authored-by: Zabil Cheriya Maliackal <[email protected]>

chadlwilson linked an issue Jun 27, 2024 that may be closed by this pull request

Unable to reuse step implementations from another project #359

Closed

Support for relative importing of step impls

229052e

Added support to reuse the step implementations from a different project using relative imports #359 Signed-off-by: Kunal Vishwasrao <[email protected]>

zabil requested changes Jun 27, 2024

View reviewed changes

Comment thread getgauge/impl_loader.py Outdated

Added temporary sys path for relative imports (#359)

e5cae86

Signed-off-by: Kunal Vishwasrao <[email protected]>

Updating temporary sys paths in load_impls method

48ce140

Signed-off-by: Kunal Vishwasrao <[email protected]>

kunalvishwasrao commented Jun 27, 2024

View reviewed changes

kunalvishwasrao requested a review from zabil June 27, 2024 16:44

zabil requested review from bugdiver and removed request for zabil June 28, 2024 09:41

bugdiver approved these changes Jul 1, 2024

View reviewed changes

bugdiver added the ReleaseCandidate label Jul 1, 2024

Bumping up gauge-python version (#360)

c6fbb72

Signed-off-by: Kunal Vishwasrao <[email protected]>

kunalvishwasrao commented Jul 1, 2024

View reviewed changes

Merge branch 'master' into feature/#359-reuse-step_impls-via-relative…

dc96ccb

…-imports

bugdiver merged commit 32e9662 into getgauge:master Jul 2, 2024

kunalvishwasrao deleted the feature/#359-reuse-step_impls-via-relative-imports branch July 2, 2024 06:10

kunalvishwasrao added a commit to kunalvishwasrao/gauge-python that referenced this pull request Jul 2, 2024

Correctly loading the methods from relatively imported classs (additi…

25439a6

…on to getgauge#360) Signed-off-by: Kunal Vishwasrao <[email protected]>

This was referenced Jul 2, 2024

Correctly loading the methods from relatively imported classes #364

Merged

Unable to correctly loading the methods from relatively imported classes #365

Closed

kunalvishwasrao added a commit to kunalvishwasrao/gauge-python that referenced this pull request Jul 3, 2024

Correctly loading the methods from relatively imported classs (additi…

4161583

…on to getgauge#360) Signed-off-by: Kunal Vishwasrao <[email protected]>

kunalvishwasrao added a commit to kunalvishwasrao/gauge-python that referenced this pull request Jul 3, 2024

Correctly loading the methods from relatively imported classs (additi…

ae4b50e

…on to getgauge#360) Signed-off-by: Kunal Vishwasrao <[email protected]>

chadlwilson mentioned this pull request Sep 27, 2024

Update Python unittests and apply Python standard #394

Merged

Navigation Menu

Repository navigation

Support for relative imports to reuse step impls - #360

Support for relative imports to reuse step impls#360
bugdiver merged 5 commits into
getgauge:masterfrom
kunalvishwasrao:feature/#359-reuse-step_impls-via-relative-imports

kunalvishwasrao commented Jun 26, 2024 •

edited

Loading

Uh oh!

Uh oh!

chadlwilson commented Jun 27, 2024

Uh oh!

bugdiver commented Jun 27, 2024 •

edited

Loading

Uh oh!

kunalvishwasrao commented Jun 27, 2024

Uh oh!

kunalvishwasrao left a comment

Uh oh!

gaugebot Bot commented Jul 1, 2024

Uh oh!

kunalvishwasrao left a comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

kunalvishwasrao commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

chadlwilson commented Jun 27, 2024

Uh oh!

bugdiver commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kunalvishwasrao commented Jun 27, 2024

Uh oh!

kunalvishwasrao left a comment

Choose a reason for hiding this comment

Uh oh!

gaugebot Bot commented Jul 1, 2024

Please bump up the version as part of this PR.

Uh oh!

kunalvishwasrao left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

kunalvishwasrao commented Jun 26, 2024 •

edited

Loading

bugdiver commented Jun 27, 2024 •

edited

Loading