Repository navigation
Conversation
query_string_matcher parsed both the request and the configured query with parse_qsl()'s default keep_blank_values=False, so a parameter with an empty value (b=, or a bare b) was dropped before comparison. As a result ?a=1 matched a request to ?a=1&b=, and a registration that required b= matched a request that omitted it. This auto-applies to any registered URL that carries a query string (via _should_match_querystring), so it silently mismatches on the default path. The request-param parser already uses keep_blank_values=True (__init__.py), so query_param_matcher treats b= as significant — the two query-matching paths disagreed on the same request. Parse both sides with keep_blank_values=True so blanks are compared, not discarded. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #804 +/- ##
==========================================
+ Coverage 99.84% 99.90% +0.06%
==========================================
Files 9 9
Lines 3295 3309 +14
==========================================
+ Hits 3290 3306 +16
+ Misses 5 3 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
In the future, you should remove the LLM checklists and noise from your pull request descriptions. It makes your contributions look like low-quality changes that are likely to be rejected by open source projects. |
markstory
approved these changes
Jul 17, 2026
Contributor
Author
|
Thanks Mark, that's fair — I've trimmed the description down to just the bug and the fix. I also corrected the disclosure line: this was AI-authored end to end, so I shouldn't have worded it as if I'd run the tests by hand. |
MateoGreil
pushed a commit
to MateoGreil/python-comwatt-client
that referenced
this pull request
Aug 28, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [responses](https://github.com/getsentry/responses) ([changelog](https://github.com/getsentry/responses/blob/master/CHANGES)) | `==0.26.2` → `==0.26.3` |  |  | --- ### Release Notes <details> <summary>getsentry/responses (responses)</summary> ### [`v0.26.3`](https://github.com/getsentry/responses/blob/HEAD/CHANGES#0263) [Compare Source](getsentry/responses@0.26.2...0.26.3) - Added a `keep_headers` argument to `_recorder.record` and `Recorder.dump_to_file` to preserve named headers (for example `Date`) that are otherwise stripped as verbose defaults, so a signed response can be recorded and later verified. Matching is case-insensitive. See [#​763](getsentry/responses#763) - Fixed the element type exposed by `CallList` so static type checkers infer `Call` values when iterating, indexing, or filtering recorded calls. See [#​722](getsentry/responses#722) - Fixed `query_string_matcher` (and the query matching auto-applied to a registered URL's own query string) discarding blank-valued query params (`b=`), which caused requests with an extra or missing blank param to match incorrectly. See [#​804](getsentry/responses#804) - Fixed `fragment_identifier_matcher` treating opaque fragments (those without `=`, e.g. `/users/5`) as always equal, so a required fragment matched a different one or none at all. See [#​806](getsentry/responses#806) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4zMC4zIiwidXBkYXRlZEluVmVyIjoiNDQuMzAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: Renovate Bot <[email protected]> Reviewed-on: https://git.greil.fr/mat/python-comwatt-client/pulls/55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
query_string_matcherparses both the incoming request query and the configured query withparse_qsl()at its defaultkeep_blank_values=False, so any empty-valued parameter (b=, or a bareb) is dropped before comparison:This matcher is auto-added for any registered URL carrying a query string (
BaseResponse._should_match_querystring), so blank params are silently ignored on both sides of the default path:It's also inconsistent with the request-param parser in
responses/__init__.py, which useskeep_blank_values=True— sorequest.paramsand the explicitquery_param_matcheralready treatb=as a real parameter.Fix: parse both sides of
query_string_matcherwithkeep_blank_values=True. Addedtest_query_string_matcher_blank_values(fails onmaster, passes with this change).Disclosure: fully AI-authored (Claude Code, autonomous) — an AI wrote the change and ran the tests; the account operator did not hand-review the diff.