Review hub management implementation #1495

Activity

1. st0012

   added

   bug

   sentry-ruby

   on Jul 2, 2021
2. st0012

   self-assigned this

   on Jul 2, 2021
3. st0012

   changed the title [-]Review state management implementation[/-] [+]Review hub management implementation[/+] on Jul 2, 2021
4. singpolyma commented on Aug 4, 2021

   

   singpolyma

   on Aug 4, 2021

   More actions

   Found this because I was reviewing the code and surprised to see a thread local variable used. I would expect each Fiber, as a separate logical context and stack, to have a different hub, but I see this was done to solve some bug related to the way Rails uses Fibers? So maybe it needs to be an option...
5. st0012

   added this to the 5.0.0 milestone on Aug 6, 2021
6. st0012 commented on Aug 6, 2021

   

   st0012

   on Aug 6, 2021

   ContributorAuthor

   More actions

   @singpolyma I'd like to give each fiber its own hub as well. But as long as users still use thread as a minimum concurrency unit instead of Fiber, it'll cause issues like #1374.

   As for adding a fiber-based option, I don't plan to do that right now. But I'll revisit this issue when we start the implementation for version 5.0.
7. github-actions commented on Oct 28, 2021

   

   github-actionsbot

   on Oct 28, 2021

   Contributor

   More actions

   This issue has gone three weeks without activity. In another week, I will close it.

   But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

   ---

   "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀
8. github-actions

   added

   Status: Stale

   on Oct 28, 2021
9. st0012

   added

   Status: Backlog

   and removed

   Status: Stale

   on Oct 28, 2021
10. st0012

    modified the milestones: 5.0.0, 6.0.0 on Jan 7, 2022
11. hubertdeng123

    removed

    Status: Backlog

    on Jul 25, 2023
12. sl0thentr0py commented on Jan 8, 2024

    

    sl0thentr0py

    on Jan 8, 2024

    Member

    More actions

    we should revisit this when we implement the new hub-free scope system.
    fwiw, opentelemtry itself uses a fiber local, if I understand correctly

    https://github.com/open-telemetry/opentelemetry-ruby/blob/ff9a7d3af31ad83ed6e07445a9e1609bec53d779/api/lib/opentelemetry/context.rb#L126-L128
13. 11 remaining items

    Load more
14. getsantry

    moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 3on Feb 25, 2025
15. sentry-triage-party

    added

    getsentry/sentry-ruby

    on Apr 8, 2025
16. linear

    added

    Task

    on Apr 9, 2025
17. stephanie-anderson

    removed

    getsentry/sentry-ruby

    on Apr 9, 2025
18. stephanie-anderson

    removed

    Task

    on Apr 25, 2025
19. stephanie-anderson

    removed the

    Task

    issue type on Apr 25, 2025
20. stephanie-anderson

    added

    Ruby

    on Apr 25, 2025
21. sl0thentr0py

    added

    6.0

    and removed

    6.0

    on Jun 30, 2025
22. sl0thentr0py

    removed this from the 6.0.0 milestone on Oct 21, 2025
23. dingsdax

    added

    Improvement

    Traces

    on Mar 19, 2026
24. sl0thentr0py

    added 3 commits that reference this issue on Jul 13, 2026

    feat: add config.isolation_level for fiber-safe hub storage

    ...

    0402b8d

    fix(rails): route ActiveJob hub save/restore through HubStorage

    ...

    545d72a

    feat: add config.hub_isolation_level for fiber-safe hub storage (Falc…

    ...

    7ab412f