Skip to content

Git sdk installer - #7

Merged
dscho merged 3 commits into
masterfrom
git-sdk-installer
Mar 3, 2015
Merged

dscho merged 3 commits into
masterfrom
git-sdk-installer

Conversation

@sschuberth

Copy link
Copy Markdown

No description provided.

This is a follow-up to 3d57873.

Signed-off-by: Sebastian Schuberth <[email protected]>
For some reason, InstallerApplicationIcon must be specified without the
.ico extension to get a proper icon for the installer executable.

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth

Copy link
Copy Markdown
Author

An installer with these changes is available for testing at https://dl.dropboxusercontent.com/u/6413030/git-sdk-i686-20150303.exe.

@nalla

nalla commented Mar 3, 2015

Copy link
Copy Markdown

Installer looks good. Worked out of the box. Could clone and compile git.

the initial startup shell after the installer finishes is MSYS though. Not MinGW.

@sschuberth

Copy link
Copy Markdown
Author

Thanks for checking. So I'll probably start setting up some CI around it.

@t-b

t-b commented Mar 3, 2015

Copy link
Copy Markdown

@sschuberth The installer works as I can compile git and all tests pass. I'm using https://github.com/dscho/git/tree/update-to-2.3.0 as my tests.

@dscho

dscho commented Mar 3, 2015

Copy link
Copy Markdown
Member

Awesome work @sschuberth!

dscho added a commit that referenced this pull request Mar 3, 2015
@dscho
dscho merged commit ba2701b into master Mar 3, 2015
@dscho
dscho deleted the git-sdk-installer branch March 3, 2015 21:54
@t-b

t-b commented Mar 3, 2015

Copy link
Copy Markdown

One thing I forgot to mention. My antivirus (Avira Pro, sorry I have to use one) always complains about the file ldh.exe containing some kind of trojan. I'll try to that sorted out on the avira side of things.

@t-b

t-b commented Mar 4, 2015

Copy link
Copy Markdown

And here is the reply from avira. With the next update ldh.exe should not be considered malicious anymore.

@sschuberth

Copy link
Copy Markdown
Author

Wow, that was quite a quick response from their side, no? Thanks @t-b!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants