Skip to content

Error creating registry key if installing as local user #455

Closed
Closed
Error creating registry key if installing as local user#455
Assignees
dscho
Labels
buginstallerneeds testingup for grabs

Description

@kjeremy
kjeremy
opened on Sep 30, 2015

In 2.6.0 I get a message box that pops up during install:

untitled

My guess is that in this case the registry keys need to be written under HKEY_CURRENT_USER.

Activity

  1. linquize commented on Sep 30, 2015

    @linquize
    linquize
    on Sep 30, 2015

    Do you have necessary registry write permission?

  2. kjeremy commented on Sep 30, 2015

    @kjeremy
    kjeremy
    on Sep 30, 2015
    Author

    No because this is an install for the user, not an admin account or global install.

  3. dakotahawkins commented on Sep 30, 2015

    @dakotahawkins
    dakotahawkins
    on Sep 30, 2015

    I had the same issue. It should be on the installer to detect whether it has permission to do that or to prompt for elevation.

  4. kjeremy commented on Sep 30, 2015

    @kjeremy
    kjeremy
    on Sep 30, 2015
    Author

    No it shouldn't prompt for elevation unless it's a machine wide install (which it does already if you run as admin). If installed for a single user the keys have to go into HKCU.

  5. dscho commented on Sep 30, 2015

    @dscho
    dscho
    on Sep 30, 2015
    Member

    I guess we need this in https://github.com/git-for-windows/build-extra/blob/master/installer/install.iss.in:

    diff --git a/installer/install.iss.in b/installer/install.iss.in
index 1f7bbe4..10d16d3 100644
--- a/installer/install.iss.in
+++ b/installer/install.iss.in
@@ -98,9 +98,12 @@ SetupWindowTitle={#APP_NAME} {#APP_VERSION} Setup

 [Registry]
 ; Aides installing third-party (credential, remote, etc) helpers
-Root: HKLM; Subkey: Software\GitForWindows; ValueType: string; ValueName: CurrentVersion; ValueData: {#APP_VERSION}; Flags: uninsdeletevalue uninsdeletekeyifempty
-Root: HKLM; Subkey: Software\GitForWindows; ValueType: string; ValueName: InstallPath; ValueData: {app}; Flags: uninsdeletevalue uninsdeletekeyifempty
-Root: HKLM; Subkey: Software\GitForWindows; ValueType: string; ValueName: LibexecPath; ValueData: {app}\{#MINGW_BITNESS}\libexec\git-core; Flags: uninsdeletevalue uninsdeletekeyifempty
+Root: HKLM; Subkey: Software\GitForWindows; ValueType: string; ValueName: CurrentVersion; ValueData: {#APP_VERSION}; Flags: uninsdeletevalue uninsdeletekeyifempty; Check: IsAdminLoggedOn
+Root: HKLM; Subkey: Software\GitForWindows; ValueType: string; ValueName: InstallPath; ValueData: {app}; Flags: uninsdeletevalue uninsdeletekeyifempty; Check: IsAdminLoggedOn
+Root: HKLM; Subkey: Software\GitForWindows; ValueType: string; ValueName: LibexecPath; ValueData: {app}\{#MINGW_BITNESS}\libexec\git-core; Flags: uninsdeletevalue uninsdeletekeyifempty; Check: IsAdminLoggedOn
+Root: HKCU; Subkey: Software\GitForWindows; ValueType: string; ValueName: CurrentVersion; ValueData: {#APP_VERSION}; Flags: uninsdeletevalue uninsdeletekeyifempty; Check: not IsAdminLoggedOn
+Root: HKCU; Subkey: Software\GitForWindows; ValueType: string; ValueName: InstallPath; ValueData: {app}; Flags: uninsdeletevalue uninsdeletekeyifempty; Check: not IsAdminLoggedOn
+Root: HKCU; Subkey: Software\GitForWindows; ValueType: string; ValueName: LibexecPath; ValueData: {app}\{#MINGW_BITNESS}\libexec\git-core; Flags: uninsdeletevalue uninsdeletekeyifempty; Check: not IsAdminLoggedOn

 ; There is no "Console" key in HKLM.
 Root: HKCU; Subkey: Console; ValueType: string; ValueName: FaceName; ValueData: Lucida Console; Flags: uninsclearvalue; Components: consolefont
  6. dscho
    added a commit that references this issue on Sep 30, 2015

    installer: put registry keys into the correct location

    7accf0e

  7. dscho commented on Sep 30, 2015

    @dscho
    dscho
    on Sep 30, 2015
    Member

    Please test this installer.

  8. dscho
    self-assigned this
    on Sep 30, 2015
  9. dscho
    added
    bug
    up for grabs
    installer
    needs testing
    on Sep 30, 2015

  10. dscho commented on Oct 1, 2015

    @dscho
    dscho
    on Oct 1, 2015
    Member

    @kjeremy @dakotahawkins Please test this installer.

  11. kjeremy commented on Oct 1, 2015

    @kjeremy
    kjeremy
    on Oct 1, 2015
    Author

    @dscho It works correctly and puts the keys in HKCU.

  12. dscho commented on Oct 1, 2015

    @dscho
    dscho
    on Oct 1, 2015
    Member

    Thanks, @kjeremy.

  13. dscho
    closed this as completedin 7accf0eon Oct 1, 2015
  14. dscho
    added a commit that references this issue on Oct 27, 2021

    Merge pull request git-for-windows#455: fetch/pull: use the sparse index

    cb9a501
  15. dscho
    added 2 commits that reference this issue on Nov 10, 2021

    Merge pull request git-for-windows#455: fetch/pull: use the sparse index

    8439a5f

    Merge pull request git-for-windows#455: fetch/pull: use the sparse index

    c521d45
  16. dscho
    added 2 commits that reference this issue on Jan 15, 2022

    Merge pull request git-for-windows#455: fetch/pull: use the sparse index

    63c4e25

    Merge pull request git-for-windows#455: fetch/pull: use the sparse index

    e29e40f
  17. kurone-kito
    added a commit that references this issue on Sep 1, 2026

    fix(windows): resolve HKCU Git root and clarify partial-apply status

    e303905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

buginstallerneeds testingup for grabs

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions