You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When installing SDK 0.4, /packages/.git/hooks/ does not contain the pre-commit hook
Actually, I didn't install the pre-commit on purpose yet, because it does not work when amending / rebasing, and there might be other cases when you don't want the hook. If at all, it should probably be an option on the last page of the installer.
I didn't install the pre-commit on purpose yet, because it does not work when amending / rebasing
I think I found out why: there is an explicit test whether the date was modified manually. And during a rebase, it looks as if it was modified manually (because it was modified in an earlier iteration of the topic branch).
Might make sense to split out the date bumping logic from the pre-commit hook so you can call it manually. Might also make sense to detect an amend/rebase and ask the user interactively (if on an interactive terminal).
To be precise, I did not verify my change, but just re-reviewed it before manually merging it. So it should work ok now when amending / rebasing. Still, this issue is about the pre-commit hook not being installed by default, and that's still the case. I intend to not spend any more time on this and keep it that way as the MSYS- / mgwport-based toolchain is more or less abandoned now in favor of MSYS2 and pacman.
Activity
dscho commentedon Oct 13, 2014
@t-b @sschuberth I hope you don't mind that I activated the issue tracker. I also added two labels:
sdkandsdk-packages.sschuberth commentedon Oct 13, 2014
Actually, I didn't install the pre-commit on purpose yet, because it does not work when amending / rebasing, and there might be other cases when you don't want the hook. If at all, it should probably be an option on the last page of the installer.
dscho commentedon Oct 13, 2014
I think I found out why: there is an explicit test whether the date was modified manually. And during a rebase, it looks as if it was modified manually (because it was modified in an earlier iteration of the topic branch).
Might make sense to split out the date bumping logic from the pre-commit hook so you can call it manually. Might also make sense to detect an amend/rebase and ask the user interactively (if on an interactive terminal).
sschuberth commentedon Jan 12, 2015
@dscho Could you please check whether sschuberth/gfw-msys1-packages#36 fixes the rebase use-case?
dscho commentedon Mar 8, 2015
@sschuberth Sorry for lagging so long; I see you verified the fix already!
sschuberth commentedon Mar 9, 2015
To be precise, I did not verify my change, but just re-reviewed it before manually merging it. So it should work ok now when amending / rebasing. Still, this issue is about the pre-commit hook not being installed by default, and that's still the case. I intend to not spend any more time on this and keep it that way as the MSYS- / mgwport-based toolchain is more or less abandoned now in favor of MSYS2 and pacman.
Post 2.3 cycle (batch #9)
Merge pull request #9 from vascool/fr
test-lib: allow selecting tests by substring/regex with --run
test-lib: allow selecting tests by substring/glob with --run
test-lib: allow selecting tests by substring/glob with --run
commit-graph: avoid leaking topo_levels slab in write_commit_graph()
114 remaining items
reftable/block: fix OOB read with bogus block size
reftable/block: fix OOB read with bogus restart count
reftable/block: fix OOB read with bogus restart offset
reftable/table: fix NULL pointer access when seeking to bogus offsets
reftable/block: fix OOB write with bogus inflated log size
reftable/block: fix OOB read with bogus block size
reftable/block: fix OOB read with bogus restart count
reftable/block: fix OOB read with bogus restart offset
reftable/table: fix NULL pointer access when seeking to bogus offsets
reftable/block: fix OOB write with bogus inflated log size
reftable/block: fix OOB read with bogus block size
reftable/block: fix OOB read with bogus restart count
reftable/block: fix OOB read with bogus restart offset
reftable/table: fix NULL pointer access when seeking to bogus offsets
builtin/history: unuse the commit buffer after use