Repository navigation
Invalid error code have been thrown: kGIDSignInErrorCodeUnknown, but should be kGIDSignInErrorCodeCanceled #471
Description
Describe the bug
If user cancel google signIn process at latest step (confirming two previous steps), the lib throws error with OIDErrorCodeProgramCanceledAuthorizationFlow that is handled as kGIDSignInErrorCodeUnknown, but it should be the same as OIDErrorCodeUserCanceledAuthorizationFlow has: kGIDSignInErrorCodeCanceled (The user canceled the sign-in flow.)
Related with react-native-google-signin
To Reproduce
Steps to reproduce the behavior:
- Go to login with Google
- Tap on 'Continue' (step 1)
- Select google account and press 'Continue' (step 2)
- On the last step select 'Cancel'.
- See 'Unknown error in google sign in. (kGIDSignInErrorCodeUnknown access_denied)' error, but it should be 'The user canceled the sign-in flow. (kGIDSignInErrorCodeCanceled)'
Expected behavior
Expected to see 'The user canceled the sign-in flow' error, not 'Unknown error in google sign in'.
Screenshots
Environment
- Device: iPhone XS
- OS: macOS Sonoma 14.5
- Browser: Chrome
Additional context
Normal google sign in.
Activity
google#471 Proper user has canceled login error code.
brnnmrls commentedon Sep 9, 2024
Hello, thanks for reporting and issuing a fix! You're right – it seems there's a mismatch between the error codes. We'll get this reviewed and aim to include this fix in our next release.
#471 Proper user has canceled login error code. (#472)