Repository navigation
feat: bundle ripgrep binaries into SEA for offline support - #25342
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enables offline support for the Gemini CLI by bundling native ripgrep binaries directly into the Single Executable Application (SEA). This change removes the runtime dependency on downloading ripgrep, ensuring the CLI remains functional in air-gapped or restricted network environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Size Change: -538 kB (-1.58%) Total Size: 33.6 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request replaces the runtime downloading of ripgrep with bundled, pre-built binaries for supported platforms and architectures. It removes the @joshua.litt/get-ripgrep dependency, adds a script to manage vendor binaries, and updates the RipGrepTool and build configuration to utilize these local assets. I have no feedback to provide.
|
✅ 59 tests passed successfully on gemini-3-flash-preview. 🧠 Model Steering GuidanceThis PR modifies files that affect the model's behavior (prompts, tools, or instructions).
This is an automated guidance message triggered by steering logic signatures. |
| @@ -0,0 +1,138 @@ | |||
| /** | |||
| * @license | |||
There was a problem hiding this comment.
nit: maybe convert this to typescript for easier maintainability going forward.
* refactor(plan): simplify policy priorities and consolidate read-only rules (google-gemini#24849) * feat(test-utils): add memory usage integration test harness (google-gemini#24876) * feat(memory): add /memory inbox command for reviewing extracted skills (google-gemini#24544) * chore(release): bump version to 0.39.0-nightly.20260408.e77b22e63 (google-gemini#24939) * fix(core): ensure robust sandbox cleanup in all process execution paths (google-gemini#24763) Co-authored-by: Spencer <[email protected]> * chore: update ink version to 6.6.8 (google-gemini#24934) * Changelog for v0.38.0-preview.0 (google-gemini#24938) Co-authored-by: gemini-cli-robot <[email protected]> Co-authored-by: g-samroberts <[email protected]> * chore: ignore conductor directory (google-gemini#22128) Co-authored-by: Coco Sheng <[email protected]> * Changelog for v0.37.0 (google-gemini#24940) Co-authored-by: gemini-cli-robot <[email protected]> Co-authored-by: Sam Roberts <[email protected]> * feat(plan): require user confirmation for activate_skill in Plan Mode (google-gemini#24946) * feat(test-utils): add CPU performance integration test harness (google-gemini#24951) * fix(core): resolve windows symlink bypass and stabilize sandbox integration tests (google-gemini#24834) * test(sdk): add unit tests for GeminiCliSession (google-gemini#21897) * fix(cli): restore file path display in edit and write tool confirmations (google-gemini#24974) * fix(cli-ui): enable Ctrl+Backspace for word deletion in Windows Terminal (google-gemini#21447) * fix(core): dynamic session ID injection to resolve resume bugs (google-gemini#24972) * Update ink version to 6.6.9 (google-gemini#24980) * feat(core): refine shell tool description display logic (google-gemini#24903) * Generalize evals infra to support more types of evals, organization and queuing of named suites (google-gemini#24941) * fix(cli): optimize startup with lightweight parent process (google-gemini#24667) * refactor(sandbox): use centralized sandbox paths in macOS Seatbelt implementation (google-gemini#24984) * feat(cli): refine tool output formatting for compact mode (google-gemini#24677) * fix(sdk): skip broken sendStream tests to unblock nightly (google-gemini#25000) * refactor(core): use centralized path resolution for Linux sandbox (google-gemini#24985) * Support ctrl+shift+g (google-gemini#25035) * feat(core): refactor subagent tool to unified invoke_subagent tool (google-gemini#24489) * fix(core): add explicit git identity env vars to prevent sandbox checkpointing error (google-gemini#19775) Co-authored-by: David Pierce <[email protected]> * fix: respect hideContextPercentage when FooterConfigDialog is closed without changes (google-gemini#24773) Co-authored-by: Coco Sheng <[email protected]> * fix(cli): suppress unhandled AbortError logs during request cancellation (google-gemini#22621) * Automated documentation audit (google-gemini#24567) * feat(cli): implement useAgentStream hook (google-gemini#24292) Co-authored-by: Adam Weidman <[email protected]> Co-authored-by: Adam Weidman <[email protected]> * refactor(core): remove legacy subagent wrapping tools (google-gemini#25053) * refactor(plan) Clean default plan toml (google-gemini#25037) * fix(core): honor retryDelay in RetryInfo for 503 errors (google-gemini#25057) * fix(core): remediate subagent memory leaks using AbortSignal in MessageBus (google-gemini#25048) * feat(cli): wire up useAgentStream in AppContainer (google-gemini#24297) Co-authored-by: Adam Weidman <[email protected]> Co-authored-by: Adam Weidman <[email protected]> * feat(core): migrate chat recording to JSONL streaming (google-gemini#23749) * fix(core): clear 5-minute timeouts in oauth flow to prevent memory leaks (google-gemini#24968) * fix(sandbox): centralize async git worktree resolution and enforce read-only security (google-gemini#25040) * feat(test): add high-volume shell test and refine perf harness (google-gemini#24983) * fix(core): silently handle EPERM when listing dir structure (google-gemini#25066) * Changelog for v0.37.1 (google-gemini#25055) Co-authored-by: gemini-cli-robot <[email protected]> * fix: decode Uint8Array and multi-byte UTF-8 in API error messages (google-gemini#23341) Co-authored-by: Coco Sheng <[email protected]> * Automated documentation audit results (google-gemini#22755) * debugging(ui): add optional debugRainbow setting (google-gemini#25088) * fix: resolve lifecycle memory leaks by cleaning up listeners and root closures (google-gemini#25049) * docs(cli): updates f12 description to be more precise (google-gemini#15816) * fix(cli): mark /settings as unsafe to run concurrently (google-gemini#25061) * fix(core): remove buffer slice to prevent OOM on large output streams (google-gemini#25094) * feat(core): persist subagent agentId in tool call records (google-gemini#25092) * chore(core): increase codebase investigator turn limits to 50 (google-gemini#25125) * refactor(core): consolidate execute() arguments into ExecuteOptions (google-gemini#25101) * feat(core): add Strategic Re-evaluation guidance to system prompt (google-gemini#25062) * fix(core): preserve shell execution config fields on update (google-gemini#25113) * docs: add vi shortcuts and clarify MCP sandbox setup (google-gemini#21679) Co-authored-by: Jenna Inouye <[email protected]> * fix(cli): pass session id to interactive shell executions (google-gemini#25114) * fix(cli): resolve text sanitization data loss due to C1 control characters (google-gemini#22624) * feat(core): add large memory regression test (google-gemini#25059) * fix(core): resolve PTY exhaustion and orphan MCP subprocess leaks (google-gemini#25079) * chore: switch from keytar to @github/keytar (google-gemini#25143) * chore(deps): update vulnerable dependencies via npm audit fix (google-gemini#25140) * perf(sandbox): optimize Windows sandbox initialization via native ACL application (google-gemini#25077) * fix: improve audio MIME normalization and validation in file reads (google-gemini#21636) Co-authored-by: Coco Sheng <[email protected]> * docs: Update docs-audit to include changes in PR body (google-gemini#25153) * docs: correct documentation for enforced authentication type (google-gemini#25142) * fix(cli): exclude update_topic from confirmation queue count (google-gemini#24945) * Memory fix for trace's streamWrapper. (google-gemini#25089) * fix(core): fix quota footer for non-auto models and improve display (google-gemini#25121) * docs(contributing): clarify self-assignment policy for issues (google-gemini#23087) * feat(core): add skill patching support with /memory inbox integration (google-gemini#25148) * Stop suppressing thoughts and text in model response (google-gemini#25073) * fix(release): prefix git hash in nightly versions to prevent semver normalization (google-gemini#25304) * feat(cli): extract QuotaContext and resolve infinite render loop (google-gemini#24959) * refactor(core): extract and centralize sandbox path utilities (google-gemini#25305) Co-authored-by: David Pierce <[email protected]> * feat(ui): added enhancements to scroll momentum (google-gemini#24447) * fix(core): replace custom binary detection with isbinaryfile to correctly handle UTF-8 (U+FFFD) (google-gemini#25297) * feat(agent): implement tool-controlled display protocol (Steps 2-3) (google-gemini#25134) * Stop showing scrollbar unless we are in terminalBuffer mode (google-gemini#25320) * fix(core): expose GEMINI_PLANS_DIR to hook environment (google-gemini#25296) Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * feat: support auth block in MCP servers config in agents (google-gemini#24770) * feat(core): implement silent fallback for Plan Mode model routing (google-gemini#25317) * fix: correct redirect count increment in fetchJson (google-gemini#24896) Co-authored-by: Tommaso Sciortino <[email protected]> * fix(core): prevent secondary crash in ModelRouterService finally block (google-gemini#25333) * feat(core): introduce decoupled ContextManager and Sidecar architecture (google-gemini#24752) * docs(core): update generalist agent documentation (google-gemini#25325) * chore(mcp): check MCP error code over brittle string match (google-gemini#25381) * test(core): improve sandbox integration test coverage and fix OS-specific failures (google-gemini#25307) Co-authored-by: David Pierce <[email protected]> * feat(plan): update plan mode prompt to allow showing plan content (google-gemini#25058) * fix(core): use debug level for keychain fallback logging (google-gemini#25398) * feat(test): add a performance test in asian language (google-gemini#25392) * feat(cli): enable mouse clicking for cursor positioning in AskUser multi-line answers (google-gemini#24630) * fix(core): detect kmscon terminal as supporting true color (google-gemini#25282) Co-authored-by: Adib234 <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * ci: add agent session drift check workflow (google-gemini#25389) * use macos-latest-large runner where applicable. (google-gemini#25413) * Changelog for v0.37.2 (google-gemini#25336) Co-authored-by: gemini-cli-robot <[email protected]> * chore(release): bump version to 0.40.0-nightly.20260414.g5b1f7375a (google-gemini#25420) * Fix(core): retry additional OpenSSL 3.x SSL errors during streaming (google-gemini#16075) (google-gemini#25187) * fix(core): prevent YOLO mode from being downgraded (google-gemini#25341) * feat: bundle ripgrep binaries into SEA for offline support (google-gemini#25342) * Changelog for v0.39.0-preview.0 (google-gemini#25417) Co-authored-by: gemini-cli-robot <[email protected]> Co-authored-by: Sam Roberts <[email protected]> * feat(test): add large conversation scenario for performance test (google-gemini#25331) * improve(core): require recurrence evidence before extracting skills (google-gemini#25147) * test(evals): add subagent delegation evaluation tests (google-gemini#24619) * feat: add github colorblind themes (google-gemini#15504) Co-authored-by: Coco Sheng <[email protected]> * fix(core): honor GOOGLE_GEMINI_BASE_URL and GOOGLE_VERTEX_BASE_URL (google-gemini#25357) * fix(cli): clean up slash command IDE listeners (google-gemini#24397) Co-authored-by: Tommaso Sciortino <[email protected]> * Changelog for v0.38.0 (google-gemini#25470) Co-authored-by: gemini-cli-robot <[email protected]> * fix(evals): update eval tests for invoke_agent telemetry and project-scoped memory (google-gemini#25502) * Changelog for v0.38.1 (google-gemini#25476) Co-authored-by: gemini-cli-robot <[email protected]> Co-authored-by: Sam Roberts <[email protected]> * feat(core): integrate skill-creator into skill extraction agent (google-gemini#25421) * feat(cli): provide default post-submit prompt for skill command (google-gemini#25327) * feat(core): add tools to list and read MCP resources (google-gemini#25395) * fix(evals): add typecheck coverage for evals, integration-tests, and memory-tests (google-gemini#25480) * Use OSC 777 for terminal notifications (google-gemini#25300) * fix(extensions): fix bundling for examples (google-gemini#25542) * fix(cli): reset plan session state on /clear (google-gemini#25515) * feat(core): add .mdx support to get-internal-docs tool (google-gemini#25090) * docs(policy): mention that workspace policies are broken (google-gemini#24367) Co-authored-by: Nicolas Ouellet-Payeur <[email protected]> * fix(core): allow explicit write permissions to override governance file protections in sandboxes (google-gemini#25338) * feat(sandbox): resolve custom seatbelt profiles from $HOME/.gemini first (google-gemini#25427) Co-authored-by: Matt Van Horn <[email protected]> * Reduce blank lines. (google-gemini#25563) * fix(ui): revert preview theme on dialog unmount (google-gemini#22542) Co-authored-by: Jack Wotherspoon <[email protected]> * fix(core): fix ShellExecutionConfig spread and add ProjectRegistry save backoff (google-gemini#25382) * feat(core): Disable topic updates for subagents (google-gemini#25567) * feat(core): enable topic update narration by default and promote to general (google-gemini#25586) Co-authored-by: JAYADITYA <[email protected]> Co-authored-by: Jack Wotherspoon <[email protected]> * docs: migrate installation and authentication to mdx with tabbed layouts (google-gemini#25155) * feat(config): split memoryManager flag into autoMemory (google-gemini#25601) * fix(core): allow Cloud Shell users to use PRO_MODEL_NO_ACCESS experiment (google-gemini#25702) * fix(cli): round slow render latency to avoid opentelemetry float warning (google-gemini#25709) * docs(tracker): introduce experimental task tracker feature (google-gemini#24556) * docs(cli): fix inconsistent system.md casing in system prompt docs (google-gemini#25414) Co-authored-by: cynthialong0-0 <[email protected]> * feat(cli): add streamlined `gemini gemma` local model setup (google-gemini#25498) Co-authored-by: Abhijit Balaji <[email protected]> Co-authored-by: Samee Zahid <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Changelog for v0.38.2 (google-gemini#25593) Co-authored-by: gemini-cli-robot <[email protected]> * Fix: Disallow overriding IDE stdio via workspace .env (RCE) (google-gemini#25022) Co-authored-by: Tommaso Sciortino <[email protected]> * feat(test): refactor the memory usage test to use metrics from CLI process instead of test runner (google-gemini#25708) * feat(vertex): add settings for Vertex AI request routing (google-gemini#25513) * Fix/allow for session persistence (google-gemini#25176) * fix(core): resolve nested plan directory duplication and relative path policies (google-gemini#25138) * feat: detect new files in @ recommendations with watcher based updates (google-gemini#25256) * Allow dots on GEMINI_API_KEY (google-gemini#25497) * feat(telemetry): add flag for enabling traces specifically (google-gemini#25343) * fix(cli): use newline in shell command wrapping to avoid breaking heredocs (google-gemini#25537) * fix(cli): ensure theme dialog labels are rendered for all themes (google-gemini#24599) Co-authored-by: cynthialong0-0 <[email protected]> * fix(core): disable detached mode in Bun to prevent immediate SIGHUP of child processes (google-gemini#22620) * feat: add /new as alias for /clear and refine command description (google-gemini#17865) * fix(cli): start auto memory in ACP sessions (google-gemini#25626) * fix(core): remove duplicate initialize call on agents refreshed (google-gemini#25670) * test(e2e): default integration tests to Flash Preview (google-gemini#25753) * refactor(memory): replace MemoryManagerAgent with prompt-driven memory editing across four tiers (google-gemini#25716) * fix(cli): fix "/clear (new)" command (google-gemini#25801) * fix(core): use dynamic CLI version for IDE client instead of hardcoded '1.0.0' (google-gemini#24414) Co-authored-by: cynthialong0-0 <[email protected]> * fix(core): handle line endings in ignore file parsing (google-gemini#23895) Co-authored-by: cynthialong0-0 <[email protected]> * Fix/command injection shell (google-gemini#24170) Co-authored-by: David Pierce <[email protected]> * fix(ui): removed background color for input (google-gemini#25339) * fix(devtools): reduce memory usage and defer connection (google-gemini#24496) * fix(core): support jsonl session logs in memory and summary services (google-gemini#25816) * fix(release): exclude ripgrep binaries from npm tarballs (google-gemini#25841) * chore(release): v0.40.0-preview.2 * feat(cli): secure .env loading and enforce workspace trust in headless mode (google-gemini#25814) Co-authored-by: galz10 <[email protected]> Co-authored-by: davidapierce <[email protected]> * feat(core): enhance shell command validation and add core tools allowlist (google-gemini#25720) Co-authored-by: David Pierce <[email protected]> Co-authored-by: Keith Schaab <[email protected]> Co-authored-by: Keith Schaab <[email protected]> Co-authored-by: Emily Hedlund <[email protected]> * update FatalUntrustedWorkspaceError message to include doc link (google-gemini#25874) * chore(release): v0.40.0-preview.3 * fix(patch): cherry-pick 048bf6e to release/v0.40.0-preview.3-pr-25941 to patch version v0.40.0-preview.3 and create version 0.40.0-preview.4 (google-gemini#25942) Co-authored-by: Tommaso Sciortino <[email protected]> * chore(release): v0.40.0-preview.4 * fix(patch): cherry-pick 54b7586 to release/v0.40.0-preview.4-pr-26066 [CONFLICTS] (google-gemini#26124) Co-authored-by: David Pierce <[email protected]> * chore(release): v0.40.0-preview.5 * chore(release): v0.40.0 * Remove temporary commit message file from tracking This cleans the repository after the upstream merge and ignores the helper file so future local commits do not pollute branch diffs. * Add optional image build trigger to fork resync skill Document the final workflow trigger step for cases where a new container image is required, including the exact workflow name and inputs, and warn against passing the branch name as the version. * Clarify fork bump behavior in resync skill Document that the fork should be bumped from upstream without applying fork patches back onto the upstream release branch, keeping fork-specific changes isolated to the fork resync workflow. --------- Co-authored-by: ruomeng <[email protected]> Co-authored-by: Sri Pasumarthi <[email protected]> Co-authored-by: Sandy Tao <[email protected]> Co-authored-by: gemini-cli-robot <[email protected]> Co-authored-by: Emily Hedlund <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: Jacob Richman <[email protected]> Co-authored-by: gemini-cli-robot <[email protected]> Co-authored-by: g-samroberts <[email protected]> Co-authored-by: JAYADITYA <[email protected]> Co-authored-by: Coco Sheng <[email protected]> Co-authored-by: Sam Roberts <[email protected]> Co-authored-by: Adamya Singh <[email protected]> Co-authored-by: Jarrod Whelan <[email protected]> Co-authored-by: dogukanozen <[email protected]> Co-authored-by: Tommaso Sciortino <[email protected]> Co-authored-by: Christian Gunderman <[email protected]> Co-authored-by: Sehoon Shon <[email protected]> Co-authored-by: Abhi <[email protected]> Co-authored-by: MD. MOHIBUR RAHMAN <[email protected]> Co-authored-by: David Pierce <[email protected]> Co-authored-by: chernistry <[email protected]> Co-authored-by: euxaristia <[email protected]> Co-authored-by: Michael Bleigh <[email protected]> Co-authored-by: Adam Weidman <[email protected]> Co-authored-by: Adam Weidman <[email protected]> Co-authored-by: Yuna Seol <[email protected]> Co-authored-by: June <[email protected]> Co-authored-by: Aishanee Shah <[email protected]> Co-authored-by: Jason Matthew Suhari <[email protected]> Co-authored-by: Christopher Thomas <[email protected]> Co-authored-by: Jenna Inouye <[email protected]> Co-authored-by: cynthialong0-0 <[email protected]> Co-authored-by: M Junaid Shaukat <[email protected]> Co-authored-by: Abhijit Balaji <[email protected]> Co-authored-by: Mark Griffith <[email protected]> Co-authored-by: Jack Wotherspoon <[email protected]> Co-authored-by: Jesse Rosenstock <[email protected]> Co-authored-by: Adib234 <[email protected]> Co-authored-by: Dev Randalpura <[email protected]> Co-authored-by: Anjaligarhwal <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Tanmay Vartak <[email protected]> Co-authored-by: Jerop Kipruto <[email protected]> Co-authored-by: Kevin Zhao <[email protected]> Co-authored-by: joshualitt <[email protected]> Co-authored-by: Clay <[email protected]> Co-authored-by: Adam Weidman <[email protected]> Co-authored-by: Rob Clevenger <[email protected]> Co-authored-by: Gal Zahavi <[email protected]> Co-authored-by: anj-s <[email protected]> Co-authored-by: Z1xus <[email protected]> Co-authored-by: jackyliuxx <[email protected]> Co-authored-by: Nicolas Ouellet-Payeur <[email protected]> Co-authored-by: Nicolas Ouellet-Payeur <[email protected]> Co-authored-by: Matt Van Horn <[email protected]> Co-authored-by: Matt Van Horn <[email protected]> Co-authored-by: Mahima Shanware <[email protected]> Co-authored-by: Timo <[email protected]> Co-authored-by: Samee Zahid <[email protected]> Co-authored-by: Samee Zahid <[email protected]> Co-authored-by: Mundur <[email protected]> Co-authored-by: Gordon Hui <[email protected]> Co-authored-by: Muhammad Ahsan Farooq <[email protected]> Co-authored-by: PRAS Samin <[email protected]> Co-authored-by: Danyel Cabello <[email protected]> Co-authored-by: Vedant Mahajan <[email protected]> Co-authored-by: mini2s <[email protected]> Co-authored-by: Kishan Patel <[email protected]> Co-authored-by: xoma-zver <[email protected]> Co-authored-by: Horizon_Architect_07 <[email protected]> Co-authored-by: galz10 <[email protected]> Co-authored-by: Keith Schaab <[email protected]> Co-authored-by: Keith Schaab <[email protected]> Co-authored-by: codex-bot <[email protected]>

Summary
This PR bundles
ripgrepnative binaries directly into the Gemini CLI's Single Executable Application (SEA).Details
ripgrepbinaries for the 5 major architectures (Linux x64/arm64, macOS x64/arm64, Windows x64) are now checked intopackages/core/vendor/ripgrep.scripts/copy_bundle_assets.jsto ensure the vendor directory is included in thebundle/folder during the SEA build process.packages/core/src/tools/ripGrep.tsto asynchronously check multiple potential paths for thergexecutable, supporting both local development and the flattened SEA runtime environment.scripts/download-ripgrep-binaries.jswith proper Apache license headers and documentation to allow maintainers to easily update the checked-in binaries.Related Issues
Replaces and fixes #25332
How to Validate
packages/core/vendor/ripgrepand then runnode scripts/download-ripgrep-binaries.jsto verify the maintainer script correctly fetches all 5 architectures.node scripts/build_binary.jsto generate a native SEA executable.Ripgrep is not available. Falling back to GrepTool.Pre-Merge Checklist