Repository navigation
Show Citations by default for all users. - #8570
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @scidomino, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request standardizes the display of citations by enabling them by default for all users. It streamlines the underlying code responsible for this feature by removing unnecessary checks related to user tiers and updates the relevant documentation to reflect this new default behavior, ensuring a consistent experience across the application.
Highlights
- Default Citation Display: The default setting for
ui.showCitationshas been changed fromfalsetotrue, meaning citations will now be displayed by default for all users. - Simplified Citation Logic: The internal logic for determining whether to show citations has been simplified, removing the dependency on user tier information and
getCodeAssistServer. - Documentation Update: The
configuration.mddocumentation has been updated to reflect the new default value forui.showCitations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request changes the default behavior to show citations for all users. This is achieved by simplifying the showCitations function in useGeminiStream.ts to default to true if no user setting is specified, removing the previous logic that depended on the user's tier. The documentation for the ui.showCitations setting has also been updated to reflect the new default. The changes are correct, clean, and effectively implement the intended feature. I have not found any high or critical issues in this pull request.
|
Size Change: -131 B (0%) Total Size: 17.3 MB ℹ️ View Unchanged
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
904300a to
4a41462
Compare
4a41462 to
1908b0d
Compare
1908b0d to
e47a23a
Compare
TLDR
Show citations for default for all users.
Reviewer Test Plan
Don't specify showCitations in your settings.json and ask it to tell a fairytale without looking it up.
Testing Matrix
Linked issues / bugs
Fixes #8300