This repository was archived by the owner on Jan 21, 2026. It is now read-only.
Repository navigation
Display contents of label values of object type - #346
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
PTAL. |
ofrobots
reviewed
Jan 13, 2017
| */ | ||
| TraceSpan.prototype.setLabel = function(key, value) { | ||
| this.labels[key] = '' + value; | ||
| this.labels[key] = typeof value === 'object' ? util.inspect(value) : '' + value; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
approved these changes
Jan 14, 2017
ofrobots
left a comment
ofrobots
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
In the future it would be good to expose a inspect depth property that could be passed to util.inspect to allow people to customize how deep an inspection should happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.