Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

Shorten method bodies - #214

Merged
geigerj merged 4 commits into
googleapis:masterfrom
geigerj:shorter-methods
Jun 14, 2016
Merged

Shorten method bodies#214
geigerj merged 4 commits into
googleapis:masterfrom
geigerj:shorter-methods

Conversation

@geigerj

@geigerj geigerj commented Jun 9, 2016

Copy link
Copy Markdown
Contributor

@geigerj

geigerj commented Jun 9, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

We should ensure compatibility with googleapis/gax-python#107

@geigerj geigerj mentioned this pull request Jun 9, 2016
Merged
@geigerj

geigerj commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

cc: @garrettjonesgoogle

jmuk
jmuk reviewed Jun 9, 2016
View reviewed changes
Comment thread src/test/java/com/google/api/codegen/testdata/python_main_library.baseline
platform.python_version()
)
self._headers = [('x-goog-api-client', goog_api_client)]
self.stub = config.create_stub(

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@bjwatson

bjwatson commented Jun 14, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Sorry @geigerj. I ran out of time to review this, due to working on the release of the logging API. I skimmed over this and nothing jumps out as being a problem, but I didn't do a proper review.

Can @garrettjonesgoogle review this instead? Thanks.

@geigerj

geigerj commented Jun 14, 2016

Copy link
Copy Markdown
Contributor Author

No problem, I'll switch out the assignees.

@bjwatson

bjwatson commented Jun 14, 2016 via email

Copy link
Copy Markdown
Contributor

garrettjonesgoogle
garrettjonesgoogle reviewed Jun 14, 2016
View reviewed changes
Comment thread src/main/resources/com/google/api/codegen/py/main.snip Outdated
client_config,
config.STATUS_CODE_NAMES,
timeout)
timeout

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle

garrettjonesgoogle commented Jun 14, 2016

Copy link
Copy Markdown
Contributor

Just one missing comma that needs to be fixed - otherwise LGTM.

jmuk
jmuk reviewed Jun 14, 2016
View reviewed changes
Comment thread src/test/java/com/google/api/codegen/testdata/python_main_library.baseline Outdated
client_config,
config.STATUS_CODE_NAMES,
timeout,
metadata=metadata,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@geigerj
PR fixes
b58b0be 
- Fixed args passed to construct_settings
- Added a missing comma
@jmuk

jmuk commented Jun 14, 2016

Copy link
Copy Markdown
Contributor

LGTM

@geigerj
geigerj merged commit 1117535 into googleapis:master Jun 14, 2016
ethanbao pushed a commit to ethanbao/toolkit that referenced this pull request Jul 19, 2016
@geigerj @ethanbao
Shorten method bodies (googleapis#214)
724cc6d 
* Simplify Python method bodies

This commit is the codegen component of googleapis/gax-python#104
@geigerj
geigerj deleted the shorter-methods branch November 28, 2016 23:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jmuk jmuk

@garrettjonesgoogle garrettjonesgoogle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@geigerj @bjwatson @garrettjonesgoogle @jmuk