Skip to content

Enable google/cloud/channel on on multiple platforms #8125

Closed
Closed
Enable google/cloud/channel on on multiple platforms#8125
Labels
api: cloudchannelIssues related to the Channel Services API.externalThis issue is blocked on a bug with the actual product.type: cleanupAn internal cleanup or hygiene concern.

Description

@devjgm
devjgm
opened on Jan 26, 2022

#8116 adds the google/cloud/channel library. However, that build breaks on macos due to:

bazel-out/darwin-fastbuild/bin/external/com_google_googleapis/google/cloud/channel/v1/common.pb.h:545:33: error: expected member name or ';' after declaration specifiers
  static constexpr CustomerType DOMAIN =
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Applications/Xcode_12.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/math.h:732:17: note: expanded from macro 'DOMAIN'
#define DOMAIN          1
                        ^

https://source.cloud.google.com/results/invocations/8ee5da3b-6410-4185-a0d2-b38f5282069c/targets/cloud-cpp%2Fgithub%2Fgoogle-cloud-cpp%2Fmain%2Fmacos%2Fbazel-presubmit/log

That is, protobuf-generated code uses a symbol named DOMAIN that conflicts w/ a macro definition.

We will temporarily disable this library on macos, and re-enable it once protobuf is fixed to not choke on DOMAIN.

Originally posted by @devjgm in #8115 (comment)

Activity

  1. yoshi-automation
    added
    triage meI really want to be triaged.
    on Jan 27, 2022
  2. coryan
    changed the title [-]Enable google/cloud/channel on macos[/-] [+]Enable google/cloud/channel on macOS[/+] on Jan 27, 2022
  3. coryan
    added
    type: cleanupAn internal cleanup or hygiene concern.
    and removed
    triage meI really want to be triaged.
    on Jan 27, 2022

  4. devjgm commented on Jan 27, 2022

    @devjgm
    devjgm
    on Jan 27, 2022
    ContributorAuthor

    The fix was submitted internally in cl/424720867. Now we need to wait for a release that contains the fix.

  5. coryan
    added this to the All GCP Services have a GA library milestone on Jan 28, 2022
  6. coryan
    added
    api: cloudchannelIssues related to the Channel Services API.
    externalThis issue is blocked on a bug with the actual product.
    on Jan 28, 2022

  7. coryan commented on Feb 5, 2022

    @coryan
    coryan
    on Feb 5, 2022
    Contributor

    This is also a problem on Windows.

  8. coryan commented on Jul 8, 2022

    @coryan
    coryan
    on Jul 8, 2022
    Contributor

    I sent a CL to fix Protobuf, but it will take a while to seep into the open source version.

  9. coryan
    modified the milestones: All GCP Services have a GA library: M1, All GCP Services have a GA library: M2 on Dec 7, 2022
  10. coryan
    changed the title [-]Enable google/cloud/channel on macOS[/-] [+]Enable google/cloud/channel on on multiple platforms[/+] on Jan 21, 2023
  11. coryan
    self-assigned this
    on May 24, 2023

  12. coryan commented on May 25, 2023

    @coryan
    coryan
    on May 25, 2023
    Contributor

    Still blocked on GCC < 8. I will send a PR to Protobuf, since we have about a year left with GCC 7.

  13. coryan
    removed their assignment
    on May 25, 2023
  14. copybara-service
    added 3 commits that reference this issue on May 26, 2023

    feat: workaround for `DOMAIN` macro (#12903)

    f71f7ff

    feat: workaround for `DOMAIN` macro (#12903)

    853dc4e

    feat: workaround for `DOMAIN` macro (#12903)

    9c479e8
  15. h-vetinari
    added a commit that references this issue on Jun 5, 2023

    feat: workaround for `DOMAIN` macro (protocolbuffers#12903)

    4f536be
  16. coryan
    removed this from the All GCP Services have a GA library: M2 milestone on Jun 9, 2023
  17. bithium
    added a commit that references this issue on Sep 4, 2023

    feat: workaround for `DOMAIN` macro (protocolbuffers#12903)

    ab8826a

  18. coryan commented on Nov 29, 2023

    @coryan
    coryan
    on Nov 29, 2023
    Contributor

    This is now fixed.

  19. coryan
    closed this as completedon Nov 29, 2023
  20. coryan
    reopened this on Nov 29, 2023
  21. coryan
    closed this as completedon Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: cloudchannelIssues related to the Channel Services API.externalThis issue is blocked on a bug with the actual product.type: cleanupAn internal cleanup or hygiene concern.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions