SPF parser bug fixed in package dns-zonefile

Hello, I'm the maintainer of the package dns-zonefile. I saw this package is depending on a specific version (0.1.10) of dns-zonefile, which had serious bugs on parsing SPF and TXT records. The latest version has greatly improved the parsers and fixed all known bugs. Now it might be an option for you to update the dependency and move it on to the up to date version. Thanks.

@elgs

Awesome! Thanks for the heads up @elgs

@stephenplusplus - can we take a look ?

@elgs

@elgs thanks for opening an issue about this! I upgraded locally, but the latest version of dns-zonefile is breaking one of our e2e tests.

  1) dns Zones should import records from a zone file:

      Uncaught AssertionError: '"-all"' === '"v=spf1" "mx:gcloud-node.com." "-all"'
      + expected - actual

      -"-all"
      +"v=spf1" "mx:gcloud-node.com." "-all"

      at system-test/dns.js:205:22

It would seem that some of the values we're testing for are being stripped out. Would you be able to provide me with any clues as to why this might be happening?

@callmehiphop

@callmehiphop I know what's wrong. That does not mean the old version is anywhere near correct, because in the old version, the mx in the SPF record could fool the parse to parse it as an mx record if SPF is parse first. I will fixed and get back here soon. Thanks.

@callmehiphop

@callmehiphop I have released `dns-zonefile v0.1.18', which should have fixed the SPF parser problem. This release introduced a zone file resource record normalizer which eliminated assumptions of record format and sticks to the RFC1035. Would you please help run your test again and let me know if it works. Thanks.

@elgs

@elgs that appears to have fixed it, thanks! I'll make a PR to bump the version of dns-zonefile shortly. Thanks again for opening this issue and for the quick fix! 👍