Storage: file.copy, file.move(, others?) don't accept "gs://" URLs

I was rather surprised when this command:

bucket.file("foo").copy("gs://otherbucket/something", cb)

created an object in the original bucket in a "gs:/" subdirectory. I see how to do what I want by passing a file or bucket instead of a string, but it seems like this could easily be supported with something like this:

--- lib/storage/file.js
+++ lib/storage/file.js
@@ File.prototype.copy = function(destination, callback) { @@
  if (is.string(destination)) {
+   if (destination.startsWith("gs://") {
+     var parsed = /^gs\:\/\/([a-z_\.\-]+)\/(.+)$/.exec(destination);
+     // assert parsed.length === 3
+     destBucket = parsed[1];
+     destName = parsed[2];
+   } else {
+     destBucket = this.bucket;
+     destName = destination;
+   }
-   destBucket = this.bucket;
-   destName = destination;
  } else if (destination.constructor &&

(Happy to make a PR with something like that.)

I'm totally cool with that. A PR would be great! Only note is to use indexOf instead of startsWith since we still support 0.12. Thanks!

Thanks. Heading out of town, probably won't get to a PR until ~10 July.

Sounds good, safe travels!

feat(storage): support gs:// copy/move dests (#1416)

docs: add short mode query sample (#1395)

fix: support byte values in Bundles (#1395)

chore(nodejs): remove api-extractor dependencies (#1395)

Navigation Menu

Repository navigation

Storage: file.copy, file.move(, others?) don't accept "gs://" URLs #1395

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Storage: file.copy, file.move(, others?) don't accept "gs://" URLs #1395

Description

Activity

stephenplusplus commented on Jun 26, 2016

zbjornson commented on Jun 28, 2016

stephenplusplus commented on Jun 29, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions