Module instancing problem with storage+bigquery.import

Hi,

I am trying to switch to the new method of requiring only the modules that I need instead of the entire google-cloud module. I'm running into a problem importing files from cloud storage into bigquery. This was working until I switched to requiring separate modules.

const bigQuery = require('@google-cloud/bigquery')({
  projectId: [projectId],
  client_email: [email],
  private_key: [key string]
});

const gcs = require('@google-cloud/storage')({
  projectId: [projectId],
  client_email: [email],
  private_key: [key string]
});

var file = gcs.bucket([bucket name]).file('afile.csv');

// This debug output prints "true"
console.log(file instanceof require("@google-cloud/storage").File);

bigQuery
  .dataset([dataset ID])
  .table([table ID])
  .import([file], next);

The import call fails with:

Error: Source must be a File object.
    at /[project dir]/node_modules/@google-cloud/bigquery/src/table.js:809:15

Adding a debug prop to require('@google-cloud/storage'), it looks like my app and the bigquery modules have two different instances of the storage module, causing instanceof to report the files passed as being the wrong type.

Environment details

OS: OSX 10.11.6
Node.js version: v4.4.4
npm version: 2.15.1
gcloud-node version: v0.1.1 for both /bigquery and /storage

This seems like a bug, but I could be missing something. Any help would be appreciated, thanks!

:\ Sorry about that. This is because of the way we type check for custom types. We have an issue that is suggesting a better way to do that, which would fix this at the same time. I'm going to assign that one to myself and start on it tomorrow so that hopefully we can release a fix shortly.

Closing only because #1467 will track the fix.

Excellent, thanks Stephen! For now I'm just using the entire google-cloud package so things are still working 👍

Phew 😌 Thanks for being patient with the bumps from the modularization releases!

Hi there. I'm running into the same issue. Is that no fixed?

@erdillon

@erdillon can you open a new issue, including steps to reproduce and environment information?

chore: release main (#1516)

chore: update ci.yaml template (#1516)

chore: release 4.12.1 (#1516)

feat: pass precondition parameters to gcs-resumable-upload (#1516)

chore: release 5.12.0 (#1519)

feat: pass precondition parameters to gcs-resumable-upload (googleapi…

chore: release 5.12.0 (googleapis#1519)

Navigation Menu

Repository navigation

Module instancing problem with storage+bigquery.import #1516

Environment details

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Module instancing problem with storage+bigquery.import #1516

Description

Environment details

Activity

stephenplusplus commented on Aug 22, 2016

jakeorr commented on Aug 22, 2016

stephenplusplus commented on Aug 22, 2016

erdillon commented on Sep 19, 2017

stephenplusplus commented on Sep 21, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions